Conversation
…thods removed and finish implementation in DrugExtractor CNAM-432: Refactoring tests CNAM-432: Solved requests from PR CNAM-432: Object names and unused elements resolved CNAM-432: Solved problem with ambiguity
CNAM-432: Corrected some documentation CNAM-432: Corrected failed test CNAM-432: Text document reformulation
…Refactoring-Followup-v2 Cnam 432 documentation refactoring followup v2
…omRow-methods CNAM-436: Remove fromRow methods.
CNAM-438: Correct tests. CNAM-438: Rename variable, add prescriptions to FallTransform.
…vent CNAM-438: DrugPrescription Event Transformer.
…ransfomer-in-dataset CNAM384: trackloss to transformer
CNAM-435: Added Documentation to extractor CNAM-435: Text changed to better understanding CNAM-435:Rewrite some documentation to adapt to guidelines.
…tatin-for-McoExtractor CNAM-435: Documentation added for extractors
Added an end Date to IrImb DiagnosisExtractor add documentation and change getEventEnd to cast 1600 dates to None
Added an end Date to IrImb DiagnosisExtractor
…n-for-Events CNAM-439: Created markdown for Events objects
… practitioner speciality extractions
…erentiel. Revert "Adding documentation on the sources. Adding IR_NAT_REF referentiel." Those changes should be in the Sources modification Merge Request for clarity Adding IR_NAT_REF for Nap extractor
Adding and correcting tests. Correcting test on DcirBiologyActs extractor PractitionnerClaimSpecialitySuite Modification for codecov Removing fromRow, changed NgapActSuite An error was corrected in MedicalActSuite Correction on the NgapActSuite test Correction on the order of the imports. Removed blanked lines unneeded. Taking into account reviews on the PR. Add comments, refacto on camelCase class name syntax. Taking into account reviews on the PR. - Adding new Ngap events for Ssr for future utilisation - Adding comments and documentation - Refacto on variables and class for syntax issue Adding Documentation and tests Adding Documentation and tests This is a combination of 3 commits. This is the 1st commit message: Taking into account reviews on the PR. Add comments, refacto on camelCase class name syntax. This is the commit message #2: Taking into account reviews on the PR. - Adding new Ngap events for Ssr for future utilisation - Adding comments and documentation - Refacto on variables and class for syntax issue This is the commit message #3: Adding documentation and tests Adding the definition of an Ngap act. Adding documentation and tests Correcting McoNgapActExtractor test Taking into account the review Better syntax and update on the groupID extraction for the DcirNgapActExtractor. Tests updated. Deleting a file which is not supposed to be in study but in etl/extractors Added coments on the Mco CE Ngap extractor. Adding test for SsrCEMedicalActExtractor Adding documentation and tests Adding the definition of an Ngap act. Adding documentation and tests Correcting McoNgapActExtractor test Taking into account the review Better syntax and update on the groupID extraction for the DcirNgapActExtractor. Tests updated. Deleting a file which is not supposed to be in study but in etl/extractors Added coments on the Mco CE Ngap extractor. Adding test for SsrCEMedicalActExtractor Refacto name of class NgapActConfig
Drees 106 ngap acts
CNAM-441: Added information to better explain transformer behaviour CNAM-441: Change sentence to better comprenhension
…n-for-transformer CNAM-441: Create markdown for transformer
1. a fake date for null start date in dcir 2. a day offset for start date in mco 3. bulk config for drug level
…actor Cnam 442 emergency extractor
…d anymore + some comments DREES-108 : fix SsrSource HadSource and SsrFilter test
DREES 108 Sources
CNAM-450: Update ExtractorSources to include the name. CNAM-450: Format files.
CNAM-450: First working version of the new Bulk.
CNAM-452: Add tests.
…xtractor Cnam-452: ExtractorCodes
…on-Interaction CNAM-457: MinimumDuration parameter for Interaction Transformer.
The bug deletes all the Diagnoses events of patient, if at some point he recorded a CCAM act belonging to CCAM exceptions list. The expected behaviour is to only delete the diagnosis that has the same hospital stay as the act that has the CCAM exception code.
CNAM-458: Update severity algorithm.
…ity-Update Cnam 458 fracture severity update
Cnam 456 reformat
Hotfix: Add tests. Hotfix: Add tests.
Hotfix: Correct bug on end date.
New abstraction of Patients Extractors Uniform all extractors of patients from different sources Separation of extractors and filters
kevtokev
requested changes
Oct 13, 2020
| StructField(colNames.FlowDistributionDate, DateType) :: Nil | ||
| ) | ||
|
|
||
| /* "extract" should "return a Dataset of DCIR Medical Acts" in { |
Contributor
There was a problem hiding this comment.
Why is it in /...../ ?
There is no test here
Contributor
Author
There was a problem hiding this comment.
This is for legacy code. It's better to keep them for tracing the changes and let other developers understand code
| assert(result == DcirAct.groupID.DcirAct) | ||
| } | ||
|
|
||
| /* "extract" should "return a Dataset of DCIR Biology Acts" in { |
Contributor
Author
There was a problem hiding this comment.
This is for legacy code. It's better to keep them for tracing the changes and let other developers understand code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
last commits from develop to master