Change traverse implemention to in-order traverse#216
Open
qiuchengxuan wants to merge 1 commit intoWorkiva:masterfrom
deepflowio:master
Open
Change traverse implemention to in-order traverse#216qiuchengxuan wants to merge 1 commit intoWorkiva:masterfrom deepflowio:master
qiuchengxuan wants to merge 1 commit intoWorkiva:masterfrom
deepflowio:master
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
the current traverse implemention has several weakness: 1. unable to stop traverse, thus unable to reduce traverse time complexity around O(logN) 2. out-of-order, ordinary traverse method should be pre-order, in-order, post-order, but the current implemention belongs none of them 3. memory cost, since traversing in flat levels, maximum memory usage will reach to nearly half tree width
Collaborator
|
Thank you for your contribution. I will review this more carefully in the next week or two as I interleave this with other duties. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current traverse implemention has several weakness:
complexity around O(logN)
post-order, but the current implemention belongs none of them
will reach to nearly half tree width