Skip to content

Update CWL paths#67

Draft
vedran-kasalica wants to merge 2 commits into
mainfrom
cwl-update
Draft

Update CWL paths#67
vedran-kasalica wants to merge 2 commits into
mainfrom
cwl-update

Conversation

@vedran-kasalica

Copy link
Copy Markdown
Member

This pull request updates the cwlVersion in several CWL tool files from v1.0 to v1.2 and modifies a configuration file to update a URL path to the correct one.

The changes ensure that the CWL version used aligns with our guidelines and that the template domain is well annotated.

@vedran-kasalica
vedran-kasalica marked this pull request as draft September 30, 2024 09:41
@eladrion

Copy link
Copy Markdown
Contributor

@vedran-kasalica If I see that correctly, you bump the CWL version to 1.2 here, which is done for most of the files in PR #87, too. Only one change is different, i.e. in domains/template-domain/config.json, the tool_annotations_path is set to https://raw.githubusercontent.com/Workflomics/containers/main/domains/template-domain/tools.json. In PR #87, this path is already modified to https://raw.githubusercontent.com/Workflomics/tools-and-domains/refs/heads/YOUR-BRANCH-NAME/domains/proteomics_new/tools.json. This change seems to be obsolete. I will mark the obsolete changes and the ones that could be ported to #87.

Comment thread cwl-tools/Comet/Comet.cwl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in PR #87, file cwl-tools/comet/comet.cwl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet updated in #87

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in PR #87, file cwl-tools/msfragger/msfragger.cwl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in PR #87, file cwl-tools/ms_amada/ms_amada.cwl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet updated in #87, nor in main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in PR #87, file cwl-tools/xtandem/xtandem.cwl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in PR #87, file cwl-tools/gprofiler/gprofiler.cwl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet updated in PR #87, nor in main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already set in PR #87, file cwl-tools/protCml2IdList/protCml2IdList.cwl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet updated #87, nor in main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet updated #87, nor in main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete by #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants