Skip to content

Load default CWL creator configuration dynamically from resources - #151

Merged
eladrion merged 2 commits into
mainfrom
131-dead-urls-in-defaultcwlcreator
Jan 27, 2026
Merged

Load default CWL creator configuration dynamically from resources#151
eladrion merged 2 commits into
mainfrom
131-dead-urls-in-defaultcwlcreator

Conversation

@eladrion

@eladrion eladrion commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

…rewrite calls to TestResources in tests, catch empty JSON objects on failure and implement loading the DefaultCWLCreator configuration from a file instead of hardcoded values in the code. Also, fix the wrong url to goa_human.gaf.

Pull Request Overview

This PR moves TestResources to main package as APEResources, rewrites calls to TestResources in tests, catches empty JSON objects on failure and implements loading the DefaultCWLCreator configuration from a file instead of hardcoded values in the code (as proposed by the TODO in the DefaultCWLCreator). Also, it fixes the wrong url to goa_human.gaf.

Related Issue

Resolves #131

Changes Introduced

As described in the PR overview

How Has This Been Tested?

Local run of test suite and example workflow generation as in the PR for #137.

Checklist

  • I have referenced a related issue.
  • I have followed the project’s style guidelines.
  • My changes include tests, if applicable.
  • All tests pass locally.
  • I have added myself to the CITATION.cff file, if not already present.

…rewrite calls to `TestResources` in tests, catch empty JSON objects on failure and implement loading the DefaultCWLCreator configuration from a file instead of hardcoded values in the code. Also, fix the wrong url to `goa_human.gaf`.
@eladrion eladrion linked an issue Jan 16, 2026 that may be closed by this pull request
@eladrion

Copy link
Copy Markdown
Contributor Author

Hi @vedran-kasalica, this PR fixes the wrong URL and also tackles the TODO in DefaultCWLCreator stating "FIX THIS. IT CANNOT BE HARDCODED." by loading the configuration from a resource JSON file.

@eladrion eladrion mentioned this pull request Jan 22, 2026
11 tasks
Comment thread src/main/java/nl/uu/cs/ape/solver/solutionStructure/cwl/DefaultCWLCreator.java Outdated

@vedran-kasalica vedran-kasalica left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eladrion, the changes look nice, thanks for cleaning up the inputs and the naming. I added a small comment to be aware of the method. I remember implementing a few similar methods to make the code a bit cleaner, because Java is really messy when it comes to working with JSON files.

@eladrion

Copy link
Copy Markdown
Contributor Author

@vedran-kasalica Thanks for the review, will merge after checks are completed.

@eladrion
eladrion merged commit 5d58c5e into main Jan 27, 2026
1 check passed
@eladrion
eladrion deleted the 131-dead-urls-in-defaultcwlcreator branch January 27, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead URLs in DefaultCWLCreator

2 participants