Load default CWL creator configuration dynamically from resources - #151
Merged
Conversation
…rewrite calls to `TestResources` in tests, catch empty JSON objects on failure and implement loading the DefaultCWLCreator configuration from a file instead of hardcoded values in the code. Also, fix the wrong url to `goa_human.gaf`.
Contributor
Author
|
Hi @vedran-kasalica, this PR fixes the wrong URL and also tackles the TODO in |
vedran-kasalica
approved these changes
Jan 26, 2026
vedran-kasalica
left a comment
Member
There was a problem hiding this comment.
@eladrion, the changes look nice, thanks for cleaning up the inputs and the naming. I added a small comment to be aware of the method. I remember implementing a few similar methods to make the code a bit cleaner, because Java is really messy when it comes to working with JSON files.
Contributor
Author
|
@vedran-kasalica Thanks for the review, will merge after checks are completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rewrite calls to
TestResourcesin tests, catch empty JSON objects on failure and implement loading the DefaultCWLCreator configuration from a file instead of hardcoded values in the code. Also, fix the wrong url togoa_human.gaf.Pull Request Overview
This PR moves
TestResourcesto main package asAPEResources, rewrites calls toTestResourcesin tests, catches empty JSON objects on failure and implements loading theDefaultCWLCreatorconfiguration from a file instead of hardcoded values in the code (as proposed by the TODO in theDefaultCWLCreator). Also, it fixes the wrong url togoa_human.gaf.Related Issue
Resolves #131
Changes Introduced
As described in the PR overview
How Has This Been Tested?
Local run of test suite and example workflow generation as in the PR for #137.
Checklist