-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add a Grunt task for detecting gutenberg_* names
#10554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Sounds good to me :) |
| * @return void | ||
| */ | ||
|
|
||
| function gutenberg_another_test(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| function gutenberg_another_test(){ | |
| function gutenberg_another_test() { |
|
|
||
| function gutenberg_another_test(){ | ||
|
|
||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this will be removed?
| function gutenberg_another_test(){ | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was just added to demonstrate the task works. Will not be included in the final commit.
| function gutenberg_test() { | ||
| echo 'this is a test'; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| function gutenberg_test() { | |
| echo 'this is a test'; | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. This was just added to demonstrate the task works. Will not be included in the final commit.
This adds a Grunt task that scans PHP files in the
srcdirectory forfunction gutenberg_to help prevent scenarios where one is accidentally merged from the Gutenberg plugin.Trac ticket: Core-56794
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.