-
Notifications
You must be signed in to change notification settings - Fork 0
fix: improve prismaScripts #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @exKAZUu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a specific interaction issue between Prisma and SQLite when handling PRAGMA statements, particularly in the context of Litestream integration. By switching from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
このプルリクエストは、prismaScriptsのlitestreamメソッドでSQLiteのPRAGMA文を実行する方法を改善するものです。$executeRawUnsafeから$queryRawUnsafeに変更されています。SQLiteのPRAGMA文は結果を返すことがあるため、この変更は正しく、litestreamの推奨設定を適用する際の潜在的な問題を修正します。追加されたコメントも変更理由を明確に説明しており、分かりやすいです。コードは適切で、特に問題は見当たりませんでした。良い修正だと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the Prisma SQLite PRAGMA handling for Litestream configuration. The change corrects the use of Prisma's raw SQL API to properly handle PRAGMA statements, which return results rather than just execute commands.
- Changes
$executeRawUnsafeto$queryRawUnsafefor PRAGMA statements - Adds explanatory comment referencing Litestream documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Close #
Self Check
All checks have passedon this page.WIP:.yarn test) passed.yarn lint) passed.