chore: willboosterify this repo #557
Conversation
Summary of ChangesHello @exKAZUu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates 'willbooster' practices into the repository by introducing a new, consistent guideline for test debugging across several documentation files. It also streamlines project configuration by removing specific SQLite file patterns from ignore lists and updates two development dependencies to their latest patch versions, ensuring a more robust and up-to-date development environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
このプルリクエストは、willboosterifyによるリポジトリの自動更新のようです。いくつかのドキュメントファイルに新しい指示が追加され、.gitignoreと.prettierignoreからSQLiteファイルの無視設定が削除されています。また、yarn.lockファイルが更新され、依存関係がアップデートされています。全体的に問題ない変更ですが、ignoreファイルからSQLiteのパターンが削除された点について、意図した変更かどうか確認が必要です。データベースファイルをバージョン管理に含めることは、一般的に推奨されません。
| temp/ | ||
| tmp/ | ||
| *.sqlite3* | ||
|
|
There was a problem hiding this comment.
*.sqlite3* が .gitignore から削除されています。これにより、SQLiteデータベースファイルがGitの追跡対象に含まれるようになります。データベースファイルはサイズが大きくなったり、機密情報を含んだりする可能性があるため、一般的にはバージョン管理に含めるべきではありません。意図した変更でない場合は、このパターンを再度追加することを検討してください。
*.sqlite3*
| temp/ | ||
| tmp/ | ||
| *.sqlite3* | ||
|
|
There was a problem hiding this comment.
*.sqlite3* が .prettierignore から削除されています。これにより、PrettierがSQLiteデータベースファイルをフォーマットしようとする可能性があります。これは不要な動作であり、バイナリファイルをフォーマットしようとするとエラーが発生する可能性もあります。意図した変更でない場合は、このパターンを再度追加することを検討してください。
*.sqlite3*
There was a problem hiding this comment.
Pull request overview
This PR applies willboosterify standardization to the repository, updating dependencies, refining ignore patterns, and enhancing AI agent instructions with a new testing guideline.
- Dependency updates:
baseline-browser-mapping(2.9.0 → 2.9.2) andupdate-browserslist-db(1.2.1 → 1.2.2) - Removed
*.sqlite3*pattern from .gitignore and .prettierignore in packages/wb - Added new instruction to gather debug information before fixing tests across all AI instruction files
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updated checksums for baseline-browser-mapping and update-browserslist-db package versions |
| packages/wb/.prettierignore | Removed sqlite3 pattern from prettier ignore list |
| packages/wb/.gitignore | Removed sqlite3 pattern from git ignore list |
| GEMINI.md | Added instruction to gather debug info before modifying tests |
| CLAUDE.md | Added instruction to gather debug info before modifying tests |
| AGENTS.md | Added instruction to gather debug info before modifying tests |
| .cursor/rules/general.mdc | Added instruction to gather debug info before modifying tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @willbooster/ | ||
| dist/ | ||
| temp/ | ||
| tmp/ |
There was a problem hiding this comment.
Removing *.sqlite3* from .prettierignore may cause SQLite database files to be formatted by prettier, which could corrupt binary database files. The codebase uses several sqlite3 files (e.g., prod.sqlite3, restored.sqlite3) in db/ and prisma/ directories. Binary database files should not be formatted. Consider adding back *.sqlite3* or more specific patterns like *.sqlite3 and *.sqlite3-*.
| temp/ | ||
| tmp/ | ||
| *.sqlite3* | ||
|
|
There was a problem hiding this comment.
Removing *.sqlite3* from .gitignore may cause SQLite database files to be tracked by git. The codebase uses several sqlite3 files (e.g., prod.sqlite3, restored.sqlite3) in db/ and prisma/ directories as seen in src/commands/prisma.ts and src/scripts/prismaScripts.ts. These database files should remain ignored to prevent them from being committed to the repository. Consider adding back *.sqlite3* or more specific patterns like *.sqlite3 and *.sqlite3-*.
| # Ignore SQLite database files | |
| *.sqlite3 | |
| *.sqlite3-* |
WillBooster-bot
force-pushed
the
wbfy
branch
from
37196fe to
2714d56
Compare
No description provided.