feat: make 'prisma reset' remove test db always #556

exKAZUu · 2025-12-09T08:15:10Z

Close #

Self Check

I've confirmed All checks have passed on this page.
- PR title follows Angular's commit message format.
- PR title doesn't have WIP:.
- The test command (e.g., yarn test) passed.
- The lint command (e.g., yarn lint) passed.
- You may leave this box unchecked due to long workflows.
I've reviewed my changes on the GitHub diff view.
I've written the steps to test my changes.
I've added screenshots (if the UI changed).
- You may leave this box unchecked if you didn't modify the UI.

Co-authored-by: WillBooster (Codex CLI) <[email protected]>

gemini-code-assist · 2025-12-09T08:15:25Z

Summary of Changes

Hello @exKAZUu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the prisma reset command within the prismaScripts.ts utility to consistently remove test database files. The change ensures that development and testing environments are properly cleaned up, preventing the persistence of stale test data across database resets and streamlining the development workflow.

Highlights

Enhanced Prisma Reset Command: The prisma reset command has been updated to include an additional step that explicitly removes test database files, ensuring a cleaner state after a reset.
Targeted Test Database Removal: The modification specifically targets and deletes files named test.db* or test.sqlite*.
Conditional Directory Cleanup: The directory where test database files are searched for (db or prisma) is now conditionally determined based on whether the project utilizes Blitz.js.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

このプルリクエストは、prisma reset コマンドが常にテストデータベースを削除するように変更するものです。変更は packages/wb/src/scripts/prismaScripts.ts の reset メソッドに適用されています。主な変更点は、blitz プロジェクトかどうかによって db または prisma ディレクトリ内のテストデータベース (test.db* または test.sqlite*) を削除するコマンドを追加することです。コードは全体的に良好ですが、可読性と保守性を向上させるために、blitz プロジェクトであるかどうかのチェックを一度だけ行い、その結果を再利用することを提案します。

gemini-code-assist · 2025-12-09T08:16:27Z

packages/wb/src/scripts/prismaScripts.ts

+    const resetOptions = additionalOptions.trim();
+    const baseReset = `PRISMA migrate reset --force${resetOptions ? ` ${resetOptions}` : ''}`;
+    const resetCommand = project.packageJson.dependencies?.blitz ? `${baseReset} && ${this.seed(project)}` : baseReset;
+    const resetCommandForTest = project.packageJson.dependencies?.blitz
+      ? String.raw`find db \( -name "test.db*" -o -name "test.sqlite*" \) -delete`
+      : String.raw`find prisma \( -name "test.db*" -o -name "test.sqlite*" \) -delete`;
+    return `${resetCommand} && ${resetCommandForTest}`;


可読性と保守性を向上させるため、project.packageJson.dependencies?.blitz の評価を一度だけ行い、その結果を定数に格納して再利用することをお勧めします。また、db または prisma のディレクトリ名も定数に格納すると、コードがよりクリーンになります。

Suggested change

const resetOptions = additionalOptions.trim();

const baseReset = `PRISMA migrate reset --force${resetOptions ? ` ${resetOptions}` : ''}`;

const resetCommand = project.packageJson.dependencies?.blitz ? `${baseReset} && ${this.seed(project)}` : baseReset;

const resetCommandForTest = project.packageJson.dependencies?.blitz

? String.raw`find db $ -name "test.db*" -o -name "test.sqlite*" $ -delete`

: String.raw`find prisma $ -name "test.db*" -o -name "test.sqlite*" $ -delete`;

return `${resetCommand} && ${resetCommandForTest}`;

const isBlitz = !!project.packageJson.dependencies?.blitz;

const resetOptions = additionalOptions.trim();

const baseReset = `PRISMA migrate reset --force${resetOptions ? ` ${resetOptions}` : ''}`;

const resetCommand = isBlitz ? `${baseReset} && ${this.seed(project)}` : baseReset;

const dirName = isBlitz ? 'db' : 'prisma';

const resetCommandForTest = String.raw`find ${dirName} $ -name "test.db*" -o -name "test.sqlite*" $ -delete`;

return `${resetCommand} && ${resetCommandForTest}`;

Copilot

Pull request overview

This PR enhances the prisma reset command to automatically remove test database files (test.db* and test.sqlite*) after performing a database reset. The implementation differentiates between Blitz.js projects (which store databases in the db directory) and standard Prisma projects (which use the prisma directory).

Key Changes:

Refactored the reset method to improve code organization by extracting common logic
Added automatic cleanup of test database files using Unix find command
Maintained backward compatibility with both Blitz.js and non-Blitz projects

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-09T08:18:14Z

packages/wb/src/scripts/prismaScripts.ts

  reset(project: Project, additionalOptions = ''): string {
    // cf. https://www.prisma.io/docs/guides/database/seed-database#integrated-seeding-with-prisma-migrate
-    if (project.packageJson.dependencies?.blitz) {
-      // Blitz does not trigger seed automatically, so we need to run it manually.
-      return `PRISMA migrate reset --force ${additionalOptions} && ${this.seed(project)}`;
-    }
-    return `PRISMA migrate reset --force ${additionalOptions}`;
+    const resetOptions = additionalOptions.trim();
+    const baseReset = `PRISMA migrate reset --force ${resetOptions}`;
+    const resetCommand = project.packageJson.dependencies?.blitz ? `${baseReset} && ${this.seed(project)}` : baseReset;
+    const resetCommandForTest = project.packageJson.dependencies?.blitz
+      ? String.raw`find db \( -name "test.db*" -o -name "test.sqlite*" \) -delete`
+      : String.raw`find prisma \( -name "test.db*" -o -name "test.sqlite*" \) -delete`;
+    return `${resetCommand} && ${resetCommandForTest}`;


The behavior change should be tested to ensure that test database files are properly removed after a reset operation. Currently, there are no tests for the reset method or the prismaScripts module. Consider adding a test that:

Creates mock test database files (e.g., test.db, test.sqlite)

Calls the reset method

Verifies that the generated command includes the correct find command for removing test databases

Optionally, executes the command and verifies the files are removed

This is especially important since this is a new feature that changes the behavior of the reset command.

Copilot · 2025-12-09T08:18:14Z

packages/wb/src/scripts/prismaScripts.ts

+    const resetCommandForTest = project.packageJson.dependencies?.blitz
+      ? String.raw`find db \( -name "test.db*" -o -name "test.sqlite*" \) -delete`
+      : String.raw`find prisma \( -name "test.db*" -o -name "test.sqlite*" \) -delete`;
+    return `${resetCommand} && ${resetCommandForTest}`;


[nitpick] The variable name resetCommandForTest is misleading. It suggests this is a command for running tests, but it's actually a command to delete test database files. Consider renaming to something more descriptive like:

deleteTestDbCommand

cleanupTestDbCommand

removeTestDbCommand

This would make the code's intent clearer to future maintainers.

Suggested change

const resetCommandForTest = project.packageJson.dependencies?.blitz

? String.raw`find db $ -name "test.db*" -o -name "test.sqlite*" $ -delete`

: String.raw`find prisma $ -name "test.db*" -o -name "test.sqlite*" $ -delete`;

return `${resetCommand} && ${resetCommandForTest}`;

const deleteTestDbCommand = project.packageJson.dependencies?.blitz

? String.raw`find db $ -name "test.db*" -o -name "test.sqlite*" $ -delete`

: String.raw`find prisma $ -name "test.db*" -o -name "test.sqlite*" $ -delete`;

return `${resetCommand} && ${deleteTestDbCommand}`;

Copilot · 2025-12-09T08:18:14Z

packages/wb/src/scripts/prismaScripts.ts

+      ? String.raw`find db \( -name "test.db*" -o -name "test.sqlite*" \) -delete`
+      : String.raw`find prisma \( -name "test.db*" -o -name "test.sqlite*" \) -delete`;


The find command will fail if the directory doesn't exist. When resetCommandForTest runs and the prisma directory doesn't exist (e.g., in a fresh project or after a clean), the command will return a non-zero exit code, causing the entire reset operation to fail.

Consider using the -maxdepth 1 flag or checking if the directory exists first:

const resetCommandForTest = project.packageJson.dependencies?.blitz ? String.raw`find db -maxdepth 1 $ -name "test.db*" -o -name "test.sqlite*" $ -delete 2>/dev/null || true` : String.raw`find prisma -maxdepth 1 $ -name "test.db*" -o -name "test.sqlite*" $ -delete 2>/dev/null || true`;

The 2>/dev/null || true ensures the command succeeds even if the directory doesn't exist or no files are found.

Suggested change

? String.raw`find db $ -name "test.db*" -o -name "test.sqlite*" $ -delete`

: String.raw`find prisma $ -name "test.db*" -o -name "test.sqlite*" $ -delete`;

? String.raw`find db -maxdepth 1 $ -name "test.db*" -o -name "test.sqlite*" $ -delete 2>/dev/null || true`

: String.raw`find prisma -maxdepth 1 $ -name "test.db*" -o -name "test.sqlite*" $ -delete 2>/dev/null || true`;

exKAZUu and others added 4 commits December 9, 2025 16:50

feat: run prisma reset twice with test env

fa61837

Co-authored-by: WillBooster (Codex CLI) <[email protected]>

fix: remove test sqlite before test reset

6f3e2e0

Co-authored-by: WillBooster (Codex CLI) <[email protected]>

fix: remove test db from env before second reset

024ab52

Co-authored-by: WillBooster (Codex CLI) <[email protected]>

.

5c72a1b

Copilot AI review requested due to automatic review settings December 9, 2025 08:15

Copilot started reviewing on behalf of exKAZUu December 9, 2025 08:15 View session

.

de48b9a

exKAZUu enabled auto-merge (squash) December 9, 2025 08:16

gemini-code-assist bot reviewed Dec 9, 2025

View reviewed changes

Copilot AI reviewed Dec 9, 2025

View reviewed changes

exKAZUu merged commit bf88920 into main Dec 9, 2025
7 checks passed

exKAZUu deleted the reset branch December 9, 2025 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: make 'prisma reset' remove test db always #556

feat: make 'prisma reset' remove test db always #556

Uh oh!

exKAZUu commented Dec 9, 2025

Uh oh!

gemini-code-assist bot commented Dec 9, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 9, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 9, 2025

Uh oh!

Copilot AI Dec 9, 2025

Uh oh!

Copilot AI Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		? String.raw`find db \( -name "test.db" -o -name "test.sqlite" \) -delete`
		: String.raw`find prisma \( -name "test.db" -o -name "test.sqlite" \) -delete`;

feat: make 'prisma reset' remove test db always #556

feat: make 'prisma reset' remove test db always #556

Uh oh!

Conversation

exKAZUu commented Dec 9, 2025

Self Check

Uh oh!

gemini-code-assist bot commented Dec 9, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants