Skip to content

Conversation

@exKAZUu
Copy link
Member

@exKAZUu exKAZUu commented Nov 23, 2025

Close #

Self Check

  • I've confirmed All checks have passed on this page.
    • PR title follows Angular's commit message format.
    • PR title doesn't have WIP:.
    • The test command (e.g., yarn test) passed.
    • The lint command (e.g., yarn lint) passed.
    • You may leave this box unchecked due to long workflows.
  • I've reviewed my changes on the GitHub diff view.
  • I've written the steps to test my changes.
  • I've added screenshots (if the UI changed).
    • You may leave this box unchecked if you didn't modify the UI.

@gemini-code-assist
Copy link

Summary of Changes

Hello @exKAZUu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a substantial refactoring of the wb command-line tool's internal command execution architecture. The primary goal is to enhance the maintainability and robustness of start and test commands across various project types. This is achieved by centralizing common logic, making command execution asynchronous, and implementing more explicit and reliable port and Docker container management. The changes streamline how different project frameworks integrate with the wb tool, leading to a cleaner and more consistent command definition.

Highlights

  • Command Restructuring: The core command execution logic for start and test operations has been significantly refactored and centralized within the BaseScripts class, promoting code reuse and consistency across different project types.
  • Asynchronous Command Execution: Many start and testE2E related commands are now asynchronous, allowing for more robust handling of setup and teardown processes, including port and Docker container management.
  • Improved Port and Docker Management: Dedicated utility functions (checkAndKillPortProcess, killPortContainerAndProcess) have been introduced to reliably manage and terminate processes on specific ports, including Docker containers, before starting new ones.
  • Environment Variable Handling Simplification: Direct environment variable prefixes (e.g., WB_ENV=...) have been removed from many script strings, suggesting a more centralized or implicit handling mechanism within the wb tool.
  • Project-Specific Script Simplification: Project-specific script classes (Blitz, HTTP Server, Next.js, Remix, Plain App) have been simplified by delegating common logic to the refactored BaseScripts, reducing redundancy and improving maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、wb コマンドの構造をリファクタリングするもので、素晴らしい改善だと感じました。BaseScripts クラスに共通ロジックを集約することで、コードの重複が大幅に削減され、保守性が向上しています。特に、各スクリプトクラス (blitzScripts, nextScripts など) が非常にシンプルになり、見通しが良くなりました。環境変数やポートのプロセス管理に関する処理も一元化され、より堅牢になっています。全体として非常によくできたリファクタリングですが、1点だけ軽微な修正点を提案させていただきます。

@exKAZUu exKAZUu merged commit ce68306 into main Nov 24, 2025
8 checks passed
@exKAZUu exKAZUu deleted the restructure branch November 24, 2025 01:32
@exKAZUu exKAZUu changed the title feat!: restructure wb commands feat!: restructure wb command Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants