Repository navigation
ci: 90% coverage gate on PRs + pushes to main - #1
Merged
Merged
Conversation
GitHub Actions workflow runs go build/vet/test -race on Ubuntu and fails the job if aggregate line coverage (via -coverpkg=./...) drops below 90%. Coverage profile is uploaded as an artifact so individual runs can be inspected after the fact. Test helper fix: seedConfig now resolves the config dir via internal/config.Dir() instead of hard-coding the macOS path, so the cmd/hearsay tests pass on Linux runners (XDG fallback path).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlruns build + vet +go test -race -coverpkg=./... -coverprofile=…on Ubuntu.One follow-on fix: the
seedConfigtest helper now resolves the config dir viainternal/config.Dir()instead of hard-coding the macOS path, so thecmd/hearsaytests pass on Linux runners (which use the XDG fallback).This PR is the first run that produces the
ci / teststatus check — once it lands and is green, branch protection onmaincan key off of it.Test plan
ci / test