Skip to content

🎨 Palette: Improve Voting Button Accessibility#20

Open
WeixuanZ wants to merge 1 commit intomasterfrom
palette-improve-voting-accessibility-12994430813000652407
Open

🎨 Palette: Improve Voting Button Accessibility#20
WeixuanZ wants to merge 1 commit intomasterfrom
palette-improve-voting-accessibility-12994430813000652407

Conversation

@WeixuanZ
Copy link
Owner

@WeixuanZ WeixuanZ commented Feb 3, 2026

🎨 Palette: Improve Voting Button Accessibility\n\n💡 What: Added type="button" and aria-pressed attributes to the player selection buttons in VotingPanel.tsx.\n\n🎯 Why: Standard HTML buttons used in selection grids often lack semantic state indicators. Screen reader users would hear "Button, PlayerName" but would not know if the player was selected or not. The visual cue (border/background) was inaccessible.\n\n♿ Accessibility:\n- type="button": Good practice for non-submit buttons.\n- aria-pressed: Explicitly communicates the toggle/selection state (Pressed/Not Pressed) to assistive technologies.\n\nJournal Entry: Added critical learning about aria-pressed to .Jules/palette.md.


PR created automatically by Jules for task 12994430813000652407 started by @WeixuanZ

…utton"` to voting selection buttons to prevent accidental form submission.\n- Add `aria-pressed` attribute to clearly communicate selection state to screen readers.\n- This micro-UX improvement ensures that the core gameplay interaction is accessible to users relying on assistive technologies.

Co-authored-by: WeixuanZ <39925558+WeixuanZ@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant