Remove frequency defn - #21
Open
nickie wants to merge 4 commits into
Open
Conversation
domfarolino
reviewed
Aug 10, 2026
| Complain About: accidental-2119 yes, missing-example-ids yes | ||
| Assume Explicit For: yes | ||
| Die On: warning | ||
| WPT Path Prefix: cpu-performance |
Collaborator
There was a problem hiding this comment.
In this case we should just remove this line if we don't want to link to the WPTs. I think that should fix the need to have a hidden wpt element.
Collaborator
Author
There was a problem hiding this comment.
I'm not sure what the common practice is regarding WPTs. We do have some (simple) tests in that file. I thought that including them as hidden (since we probably don't want to mention them in the text) was the correct way to link them to the spec. It did not cross my mind that we could leave them out entirely. If that's what you think is better, I'll change the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the definition of CPU frequency, that caused the automated tests to fail.
Moreover, it converts double quotes to single quotes in JS code, for consistency.
Finally, it mentions the WPT tests that have been added.
It should fix issue #20.
Preview | Diff