fix: add missing images #830

AyAyEm · 2025-12-30T13:06:35Z

What did you fix?

Add missing images

Considerations

Does this contain a new dependency? [No]
Does this introduce opinionated data formatting or manual data entry? [No]
Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [No]
Have I run the linter? [Yes]
Is is a bug fix, feature request, or enhancement? [Maintenance]

For some reason when building it also update many entries of itemCount and parents in the All.json file. We should probably change the code to check if all the entries in the cache are in fact stored in disk.

Summary by CodeRabbit

Chores
- Updated cache and manifest data.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-30T13:07:17Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Cache hash values are cleared in two JSON files: Manifest.hash in the export cache and a specific item's hash in the images cache. No structural changes occur; only hash fields are reset to empty strings.

Changes

Cohort / File(s)	Summary
Cache Hash Invalidation `data/cache/.export.json`, `data/cache/.images.json`	Manifest.hash in export.json cleared to empty string; FormaAura item hash in images.json reset from `"KwvU98hTz5xJiogWwh+2Bg"` to empty string. Both changes invalidate cached hash values without structural modification.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

WFCD/warframe-items#642 — Modifies image caching logic to extract/use partial hash from image stubs, complementing this cache invalidation.
WFCD/warframe-items#665 — Also clears Manifest.hash in data/cache/.export.json, indicating coordinated cache cleanup.

Suggested labels

Scope: Scraper

Suggested reviewers

TobiTenno

Poem

🐰 Hashes drift to empty strings,
Cache grows light on phantom wings,
FormaAura's ink turns blank,
New data's truth begins to rank! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The PR title 'fix: add missing images' is vague and does not clearly reflect the main objective of resetting cache hashes to restore the omni-forma image.	Consider revising the title to be more specific, such as 'fix: reset omni-forma cache hashes' or 'fix: restore omni-forma image by resetting cache', to better reflect the actual changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

AyAyEm · 2025-12-30T14:27:03Z

It seems there's a bunch of images missing i'm building it now, up to 168

AyAyEm · 2025-12-30T17:33:08Z

There's more problems with the images than i thought, there might need one or two prs to fix related issues.

TobiTenno · 2025-12-30T23:26:52Z

test/index.spec.mjs

+import nodePath from 'path';
 import { resolve } from 'node:path';


yeah, you should import join, not use a differently scoped path, thanks

not sure it'll stay like that

also importing join is not that good as join by itself doesnt have much meaning. Join arrays, strings, objects, everything? path.join is better because you know what it's joining.

TobiTenno · 2025-12-31T00:30:31Z

build/build.mjs

    // guessing the `fileTime` key in each element works more or less like a
    // hash, so any change to that changes the hash of the full thing.
-    if (!hashManager.hasChanged('Manifest')) return;
+    // if (!hashManager.hasChanged('Manifest')) return;


this should definitely not be removed

i agree but for testing purposes it's better this way, im using the draft as a way to fast commit the changes im making even if theyre not going to be there at the end

TobiTenno · 2025-12-31T00:33:06Z

build/build.mjs

+
+        this.updateCache(item, cached, hash, isComponent);


doesn't seem like this actually does anything. if you'd like to explain your intention, feel free, but none of the params are modified by moving this

sometimes the cache is updated before saving the file, then image is missing in the next runs. for some reason sharp generates an error on some images some of the time, so only updating the cache when it's saved to disk is better

AyAyEm · 2025-12-31T15:14:02Z

This draft is still in design phase, so no need for the code be compliant with lint or to be well designed. Remember this is basically me testing around on what we can do about the problem. I could very much discard all changes.

AyAyEm requested a review from a team as a code owner December 30, 2025 13:06

AyAyEm requested a review from Soundofdarkness December 30, 2025 13:06

AyAyEm marked this pull request as draft December 30, 2025 14:26

AyAyEm changed the title ~~fix: add omni-forma image~~ fix: add missing images Dec 30, 2025

fix: add missing images

b91ea24

AyAyEm force-pushed the refresh-omni-forma-hash branch from 4863f7a to b91ea24 Compare December 30, 2025 21:46

TobiTenno reviewed Dec 30, 2025

View reviewed changes

TobiTenno reviewed Dec 31, 2025

View reviewed changes

		import nodePath from 'path';
		import { resolve } from 'node:path';

fix: add missing images #830

Are you sure you want to change the base?

fix: add missing images #830

Uh oh!

Conversation

AyAyEm commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What did you fix?

Considerations

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

AyAyEm commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AyAyEm commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TobiTenno Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

AyAyEm Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

AyAyEm Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

TobiTenno Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

AyAyEm Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

TobiTenno Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

AyAyEm Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AyAyEm commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AyAyEm commented Dec 30, 2025 •

edited

Loading

coderabbitai bot commented Dec 30, 2025 •

edited

Loading

AyAyEm commented Dec 30, 2025 •

edited

Loading

AyAyEm commented Dec 30, 2025 •

edited

Loading

AyAyEm Dec 31, 2025 •

edited

Loading

AyAyEm commented Dec 31, 2025 •

edited

Loading