fix(types): match on class-category on weapons

[TobiTenno]

What did you fix?

to clarify weapons with multiple modes

---

Reproduction steps

---

Evidence/screenshot/link to line

Considerations

• Does this contain a new dependency? [No]
• Does this introduce opinionated data formatting or manual data entry? [Yes]
• Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [Yes]
• Have I run the linter? [Yes]
• Is is a bug fix, feature request, or enhancement? [Bug Fix]

Summary by CodeRabbit

Release Notes

• New Features

  • Added Tektolyst Artifact Mod item type
  • Added Dark Refractory, Deimos system location
  • Weapon data now includes class and slot information for better filtering

• Bug Fixes

  • Enhanced polarity transformation error handling to prevent crashes
  • Improved data validation and normalization

• Data Updates

  • Updated weapon statistics and polarity configurations
  • Corrected various item data entries and relationships

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR enhances Wikia data association with slot-aware weapon matching, adds error handling to polarity transformation, extends weapon objects with class and slot fields, introduces a new Tektolyst Artifact Mod type across configuration and type definitions, and updates numerous data entries including polarities, aura values, and attack array structures in the JSON artifact repository.

Changes

Cohort / File(s)	Summary
Wikia Data Association & Transformation Logic build/parser.mjs, build/wikia/transformers/transformPolarity.mjs, build/wikia/transformers/transformWeapon.mjs	Adds slot-aware matching layer for weapon categories (parser.mjs); wraps polarity transformation in try/catch with improved field coercion (transformPolarity.mjs); extends weapon objects with class and slot fields (transformWeapon.mjs).
Type Definitions & Configuration index.d.ts, config/itemTypes.json	Expands ModType union with 'Tektolyst Artifact' and SystemName union with 'Dark Refractory, Deimos'; adds new Tektolyst Artifact Mod entry to itemTypes configuration.
Data Artifacts data/json/All.json	Extensive updates: converts multiple item types from "--- Mod" to "Tektolyst Artifact Mod"; corrects/expands polarity arrays for several items; updates stancePolarity, aura, and wikiaUrl fields; restructures attacks array with adjusted speed, shot_type, and damage values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Slot-aware matching logic in build/parser.mjs requires verification of correctness and edge cases
• Polarity transform error handling in build/wikia/transformers/transformPolarity.mjs — ensure error path doesn't mask data issues
• All.json data integrity — extensive field updates and attack array restructuring require careful validation of correctness, particularly polarity and damage field changes

Possibly related PRs

• feat: expose 'wikiAvailable', match on uniqueName #718: Modifies Wikia item matching in build/parser.mjs with uniqueName and wikiAvailable exposure, addressing related data association concerns
• feat: added RailJack turrets #644: Adds slot-based weapon categorization (slot 14 for Railjack), complementary to the slot-aware matching introduced here
• feat: migrate all fandom links to the official wiki #700: Extends Wikia data association logic in build/parser.mjs for wikiCategory resolution, overlapping architectural concerns

Suggested labels

Scope: Data, Type: Bug, Severity3: Minor

Suggested reviewers

• EricSihaoLin
• AyAyEm

Poem

🐰 A twist of slots, a polarity guard,
New weapons wear their class with regard,
Tektolyst shines in the artifact light,
Data flows true, and attacks take flight! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(types): match on class-category on weapons' is directly related to the main changes, which add class and slot fields to weapon transformations and introduce slot-aware matching for weapon categories.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch artifact-mod

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df6f786 and 3cd0313.

📒 Files selected for processing (3)

• build/parser.mjs (1 hunks)
• build/wikia/transformers/transformWeapon.mjs (3 hunks)
• data/json/All.json (28 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• build/parser.mjs
• build/wikia/transformers/transformWeapon.mjs

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: SlayerOrnstein
Repo: WFCD/warframe-items PR: 663
File: config/masterableCategories.json:1-2
Timestamp: 2024-12-03T23:47:24.677Z
Learning: In the 'warframe-items' repository, when suggesting changes to regex patterns in 'config/masterableCategories.json', ensure that added patterns only include items relevant to the current PR context, and avoid adding items not present in the context.

Learnt from: TobiTenno
Repo: WFCD/warframe-items PR: 714
File: build/parser.mjs:451-469
Timestamp: 2025-03-29T18:52:41.800Z
Learning: Wiki data in the warframe-items builder should not have null checks as it's critical for the build process - if wiki fetch fails, the build should fail to prevent propagating incorrect data downstream.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build

🔇 Additional comments (6)

data/json/All.json (6)

1065634-1065646: Verify Vinquibus attack array restructuring.

The changes to the attack structure for Vinquibus are significant: speed adjusted to 1.5, shot_type changed to "Hit-Scan", and damage array consolidated. Please confirm these modifications reflect the correct weapon data and align with wiki data or intended transformations mentioned in the PR.

---

554297-554297: Clarify the Melee Careen type change.

Hunk 13 changes the type to "Melee Arcane", which breaks from the systematic "Tektolyst Artifact Mod" pattern seen throughout the other hunks. Please confirm this is intentional and aligns with the weapon classification changes in this PR.

---

319341-319341: Verify weapon polarity updates.

Polarity arrays are updated for Galariak Prime (hunk 5: ["madurai", "madurai"]) and Sagek Prime (hunk 17: ["madurai", "naramon"]). Confirm these reflect accurate data from the game and are not data drift errors.

Also applies to: 867575-867575

---

416658-416658: Confirm aura field normalization.

The aura field changes from the literal string "aura" to "vazarin". If this is normalizing an incorrect value, the change is correct; please confirm this was the intended fix.

Also applies to: 416658-416658

---

207520-207525: Approve systematic type updates to "Tektolyst Artifact Mod".

The bulk updates changing item types to "Tektolyst Artifact Mod" appear systematic and align with the PR summary's mention of introducing this new mod type. These changes are consistent across all occurrences and reflect the unified data model update.

Also applies to: 251064-251069, 260912-260917, 263137-263142, 365571-365576, 381601-381606, 422064-422069, 465408-465413, 524909-524914, 617829-617834, 617920-617925, 724583-724588, 869684-869689, 892229-892234, 917824-917829, 975785-975790, 1030931-1030936, 1031095-1031100, 1065318-1065323, 1065428-1065433, 1108844-1108849

---

1065762-1065765: LGTM on Vinquibus wikiaUrl update.

The URL change to point to the primary weapon page "Vinquibus_(Primary)" is an appropriate normalization for wikia data consistency.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[wfcd-bot-boi]

🎉 This PR is included in version 1.1272.69 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀