Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves RELION compatibility issues and fixes the Y-axis coordinate flip introduced by the denoiser, addressing #46, #47, and #48 (sub-issues of #44).
Closes #46
Closes #47
Closes #48
Closes #44
Changes
Bug Fixes
Fixed: Y-axis coordinates flipped when using PartiNet denoise (#48)
.T(transpose) andnp.rot90operations fromguided_denoiser.pythat were causing micrograph Y-axis inversionFlip in yin CryoSPARC/RELION when extracting particles, and that this is no longer required in v1.0.1+Fixed: STAR file format incompatible with RELION particle extraction (#46)
star_file.py--relionflag generates apick.starmanifest and per-micrograph coordinate STAR files under<relion_project>/partinet/--relion-project-dirand--mrc-prefixCLI options added topartinet starFixed: STAR file output uses Windows line endings (CRLF) (#47)
newline="\n"andlineterminator="\n"on all STAR file writers instar_file.pyto ensure Unix line endings (LF) regardless of host OSDocumentation
README.md,getting-started.md,intro.md,denoise.md, andstar.mdto reflect RELION output support and corrected descriptionsstar.mdfor v1.0.0 Y-axis flip workaround