Fix TypeScript compilation errors in database client

[Copilot]

Fix TypeScript Compilation Errors in src/database/client.ts

Changes Completed

• Analyze the issue and understand the requirements
• Use type-only import for QueryResult to preserve explicit return type
• Add explicit type annotation err: Error for pool error handler parameter
• Fix pool configuration to use merged config ({ ...defaultConfig, ...config })
• Add @types/node devDependency for database module compilation
• Verify TypeScript compilation passes locally

Summary

Fixed TypeScript compilation errors in src/database/client.ts:

1. Type-only import for QueryResult: Uses import type { QueryResult } to preserve explicit return type while eliminating unused import error
2. Typed error handler: Added err: Error annotation for pool error event handler
3. Config merging: Uses spread operator to allow partial config overrides instead of all-or-nothing replacement
4. Added @types/node: Required devDependency for database module TypeScript compilation

CI Status Note

The current CI failures are pre-existing issues in the base branch:

• Coverage threshold failures: Repository-wide coverage is 46% (need 80%) - not related to database client changes
• Integration test failures: Schema initialization steps being skipped in workflow execution - base branch issue

My changes successfully compile locally and address all TypeScript errors in src/database/client.ts.

Original prompt

Problem

The CI build is failing with TypeScript compilation errors in src/database/client.ts:

1. Line 1: QueryResult is imported but never used
2. Line 27 (in the actual source, it's misplaced): Parameter err implicitly has an 'any' type in the pool error handler

Looking at the file structure, there's also a logical issue: the pool error handler (lines 24-27) is defined before the pool is actually created in the constructor, and it's outside the constructor entirely.

Required Changes

Fix src/database/client.ts:

1. Move the pool error handler inside the constructor, after the pool is initialized
2. Add explicit type annotation for the err parameter: err: Error
3. The pool should be created with the merged config, then the error handler should be attached

The corrected structure should be:

constructor(config?: PoolConfig) {
  const defaultConfig: PoolConfig = {
    // ... config ...
  };

  this.pool = new Pool({ ...defaultConfig, ...config });

  // Handle pool errors
  this.pool.on('error', (err: Error) => {
    console.error('Unexpected database error:', err);
  });
}

Context

This is blocking PR #91 which adds integration test infrastructure. The failing job is at:
https://github.com/Violet-Site-Systems/VEXEL/actions/runs/21322549477/job/61374809539?pr=91

The file being modified is located at: src/database/client.ts with BlobSha: 96989db698e8779d190c5de006a47d45f2891315

This pull request was created from Copilot chat.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

Fixes TypeScript build issues in the PostgreSQL DatabaseClient by cleaning up imports, tightening typing, and correcting pool configuration handling.

Changes:

• Removed the unused QueryResult import from pg.
• Corrected pool config initialization so user config overrides defaults via object spread.
• Added an explicit Error type for the pool 'error' event handler parameter.

[colleenpridemore]

ok!

[colleenpridemore]

@copilot apply changes based on the comments in this thread

[colleenpridemore]

ok!

[colleenpridemore]

checks still not passing

[colleenpridemore]

Superseded by #100