Fix inter-agent communication timeout in Aethel integration test#59
Merged
Conversation
…ification Co-authored-by: colleenpridemore <4281084+colleenpridemore@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inter-agent communication timeout in Aethel integration test
Fix inter-agent communication timeout in Aethel integration test
Jan 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a timeout issue in the Aethel integration test where inter-agent communication was hanging for 5 minutes before failing. The problem occurred because the test was sending a 'request' type message via protocol.send(), which creates a Promise that waits for a corresponding protocol.respond() call, but the test manually invoked handleMessage() directly, bypassing the protocol's response mechanism and leaving the Promise unresolved.
Changes:
- Changed message type from
'request'to'notification'on line 180 ofagents/examples/aethel-integration.js
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Aethel integration test hangs for 5 minutes then times out because
protocol.send()withtype: 'request'creates a Promise waiting forprotocol.respond(), but the test manually callshandleMessage()instead, so the Promise never resolves.Changes
'request'to'notification'inagents/examples/aethel-integration.js:180Details
The communication protocol has two distinct patterns:
The test manually invokes
aethelAgent.handleMessage()to process the message, bypassing the protocol's response mechanism. Using'notification'type is correct here since noprotocol.respond()will be called.Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.