Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion clients/javascript/src/bidi/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,22 @@ export class BiDiClient {
this.pendingCommands.delete(response.id);

if (response.type === 'error' && response.error) {
pending.reject(new Error(`${response.error}: ${response.message}`));
// Handle both flat and nested error formats for compatibility
let errorCode: string;
let errorMessage: string;

if (typeof response.error === 'object' && response.error !== null) {
// Nested format: { error: { error: "code", message: "msg" } }
const errObj = response.error as { error?: string; message?: string };
errorCode = errObj.error || 'unknown error';
errorMessage = errObj.message || 'An error occurred';
} else {
// Flat format (BiDi spec): { error: "code", message: "msg" }
errorCode = String(response.error);
errorMessage = response.message || 'An error occurred';
}

pending.reject(new Error(`${errorCode}: ${errorMessage}`));
} else {
pending.resolve(response.result);
}
Expand Down
2 changes: 1 addition & 1 deletion clients/javascript/src/bidi/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface BiDiResponse {
id: number;
type: 'success' | 'error';
result?: unknown;
error?: string;
error?: string | { error?: string; message?: string }; // Can be flat (spec) or nested (current impl)
message?: string;
}

Expand Down