Fix(python): Element.highlight() missing from client#214
Open
Jhoan0714 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR Fixes #208 - the missing
Element.highlight()method to the Python client (async and sync).el.highlight()is documented indocs/reference/api.md, implemented in the Go backend (vibium:element.highlight), and available in the Java client — but was absent fromvibium.async_api.Elementandvibium.sync_api.Element.Root Cause
Element.highlight()was documented and supported by the Go backend and Java client, but had not yet been exposed on the PythonElementclass.Changes
clients/python/src/vibium/async_api/element.pyasync def highlight(self) -> Nonein the Interaction section (afterset_files, before State queries)vibium:element.highlightwith standard_command_params()(context, selector, index, semantic params)timeoutparameter — matches Java and the backend handler, which uses instantevalElementScriptrather than actionability pollingclients/python/src/vibium/sync_api/element.py_loop.run()tests/py/test_interaction.pytest_highlightsmoke test: resolves#info, callshighlight(), verifies the BiDi command succeeds without error (same intent as Java'shighlightIsImplementedinJavaClusterFixTest)Why this matters
This closes a parity gap between the documented API and the Python client. Now python users can call
el.highlight()as documented, consistent with the Java client and CLI.Validation
Executed: