Open
Conversation
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
brenank
commented
Mar 19, 2026
test/platform-exceptions/php/vbml/layouts_absolute_components_by_relative_components.json
Outdated
Show resolved
Hide resolved
brenank
commented
Mar 19, 2026
test/platform-exceptions/python/vbml/defaults_calendar_position_to_origin.json
Outdated
Show resolved
Hide resolved
Author
|
I was looking to port to golang as well, and this was a simple way to do the validation of the port. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
brenank
force-pushed
the
brenank/improve-tests
branch
from
35c130e to
0da5e8c
Compare
brenank
force-pushed
the
brenank/improve-tests
branch
from
0da5e8c to
78c54c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a common cross language test suite to help catch behavior drift between languages
Only affects test logic, does not change any production code.
Moves common tests to live under /test
/test/inputs- contains all test cases/test/expected- test expected values for each test case (named the same)/test/language-exceptions/<language>/- same as expected, but overrides for specific expected values for a language (used to describe deviations/drift from common behavior)All language tests now utilize/import these common test cases, and run them in their respective languages, rather than reimplementing the entire suite.
I know this is a large change, so feel free to close if this is not desired, or is too much to review.