✨ Add new calldata optimal execution mode for ERC7821 #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add new commonTo execution mode, for calldata optimization * feat: add address(0) replacement to new execution mode * chore: use memory-safe-assembly tag * chore: natspec * fix: clean to address, before checking if it is 0 * feat: replace commonTo mode with calldata optimal mode * chore: replace datas with dataArr
|
Letting it marinate for a day. Gut feel says the bounds check is 90% safe, but I haven't written the tests for that yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tobeforedataArrconsistently.Integration:
solady/accounts/ERC7821.sol->solady/accounts/ext/ithaca/ERC7821.sol.Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge test?Pull requests with an incomplete checklist will be thrown out.