ci: publish Docker from release workflow#25
Conversation
Publish Docker Hub images inside the Release Please workflow when a release is created, avoiding the skipped cross-workflow release event caused by GITHUB_TOKEN-created releases. Keep docker.yml as a manual backfill workflow for existing release tags and update release documentation.
|
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in AGENTS.md and README.md to reflect changes in the release and Docker publishing workflows. Specifically, it documents that Docker images are now published as part of the main release workflow to avoid reliance on secondary triggers, and updates version references from v0.2.0 to v0.2.1 in examples. I have no feedback to provide as there were no review comments.
Summary
Why
GitHub does not trigger a second workflow from events created by the default
GITHUB_TOKEN, so a GitHub Release created by Release Please does not reliably fire a separaterelease: publishedDocker workflow. Publishing Docker in the same release workflow keeps the normal release path deterministic.Verification
ruby -e 'require "yaml"; ARGV.each { |path| YAML.load_file(path); puts path }' .github/workflows/*.ymlgit diff --check.venv/bin/python -m pytest -q.venv/bin/python -m compileall -q src/font_splitter tests.venv/bin/python -m buildRisks
release: published; this is intentional because that trigger was unreliable for releases created byGITHUB_TOKEN.