Skip to content

ci: publish Docker from release workflow#25

Merged
VdustR merged 1 commit into
mainfrom
codex/fix-release-docker-publish
May 21, 2026
Merged

ci: publish Docker from release workflow#25
VdustR merged 1 commit into
mainfrom
codex/fix-release-docker-publish

Conversation

@VdustR

@VdustR VdustR commented May 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • publish Docker Hub images from the Release Please workflow when a release is created
  • keep the Docker workflow as a manual backfill/repair path for existing release tags
  • update README and AGENTS release-flow notes to match the new behavior

Why

GitHub does not trigger a second workflow from events created by the default GITHUB_TOKEN, so a GitHub Release created by Release Please does not reliably fire a separate release: published Docker workflow. Publishing Docker in the same release workflow keeps the normal release path deterministic.

Verification

  • ruby -e 'require "yaml"; ARGV.each { |path| YAML.load_file(path); puts path }' .github/workflows/*.yml
  • git diff --check
  • .venv/bin/python -m pytest -q
  • .venv/bin/python -m compileall -q src/font_splitter tests
  • .venv/bin/python -m build

Risks

  • Docker publishing now shares the Release Please workflow. If Docker Hub publishing fails after a GitHub Release is created, the manual Docker workflow remains available for backfill.
  • The Docker workflow no longer runs on release: published; this is intentional because that trigger was unreliable for releases created by GITHUB_TOKEN.

Publish Docker Hub images inside the Release Please workflow when a release is created, avoiding the skipped cross-workflow release event caused by GITHUB_TOKEN-created releases.

Keep docker.yml as a manual backfill workflow for existing release tags and update release documentation.
@changeset-bot

changeset-bot Bot commented May 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 117b6fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@VdustR VdustR marked this pull request as ready for review May 21, 2026 07:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in AGENTS.md and README.md to reflect changes in the release and Docker publishing workflows. Specifically, it documents that Docker images are now published as part of the main release workflow to avoid reliance on secondary triggers, and updates version references from v0.2.0 to v0.2.1 in examples. I have no feedback to provide as there were no review comments.

@VdustR VdustR merged commit 0ac2e6d into main May 21, 2026
6 checks passed
@VdustR VdustR deleted the codex/fix-release-docker-publish branch May 21, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant