Implemented config parameter to turn off generic legendary item drop#8
Open
FominArtmind wants to merge 3 commits intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
Open
Conversation
added 2 commits
February 16, 2024 14:19
…daries" interaction (no sense in set drop chance filter if the latter set to true)
Author
|
Updated: fixed an issue with incorrect flags interaction. Basically, there is no sense in using "Set Item Drop Chance" if "Always Drop Unique Legendaries" set to true since in the latter case whether the item is set or not is better controlled by:
|
Author
|
Still leads to "NullReferenceException: Object reference not set to an instance of an object |
Author
|
Reworked the code to initial variant to avoid Exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: currently there is no control over generic legendary item drop. Basically, if there is only one appropriate unique not set legendary item, the chance that the legendary item drops as unique or generic one is 50/50. It's not good if someone would like to have only unique items in the game (no general legendaries at all) or possess even more granular control on legendaries drop.
Backward compatibility: doesn't effect existent users of the mod since default value for the proposed config parameter is false.