Legendary item ranges hint fix#14
Open
FominArtmind wants to merge 3 commits intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
Open
Legendary item ranges hint fix#14FominArtmind wants to merge 3 commits intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
FominArtmind wants to merge 3 commits intoVapok:releases/EpicLoot/v0.9.37-vapokfrom
Conversation
added 3 commits
February 16, 2024 17:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: if unique legendary item had had custom effect range, it was not properly shown in range hint (on shift pressing), default range for the item from magiceffects.json was shown instead.
The change provides fix to show the proper range from legendaries.json in the case.
Backward compatibility: should be full, requires FominArtmind:pr-item-name-in-magic-item to be accepted first to avoid merge conflicts