Skip to content

Refactor promiseTree add an argument to disable warning text #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor promiseTree add an argument to disable warning text #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions validate-tree/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,21 +83,24 @@ export function validateTree<I extends Instance, T extends InstanceTree>(
* the name of a child instance, which should have a corresponding value which is this same kind of tree.
* There is also a shorthand syntax available, where setting a key equal to a className is equivalent
* to an object with `$className` defined. Hence `Things: "Folder"` is equivalent to `Things: { $className: "Folder" }`
* @param warnAfter How long to wait before warning about the tree not being found.
* If the value is 0 then no warning will be given.
*/
export function promiseTree<I extends Instance, T extends InstanceTree>(
object: I,
tree: T,
warnAfter: number = 5,
): Promise<EvaluateInstanceTree<T, I>> {
if (validateTree(object, tree)) {
return Promise.resolve(object as I & EvaluateInstanceTree<T, I>);
}

const connections = new Array<RBXScriptConnection>()
const warner = Promise.delay(5)
const warner = Promise.delay(warnAfter)

warner.then(() => {
const violators = new Array<string>()
if (!validateTree(object, tree, violators))
if (warnAfter !== 0 && !validateTree(object, tree, violators))
warn(`[promiseTree] Infinite wait possible. Waiting for: ${violators.join(", ")}`)
})

Expand Down