Refactor labels and aliases - #497
Open
Schottkyc137 wants to merge 21 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, labels attached to single nodes were aliases (e.g.,
name:'#identifier'->#identifierwas spelledname()in the generated AST). Single-element nodes (Foo=Bar) generated wrapper nodes.This PR inverts this relationship: Now
name:'#identifier'would generate a new wrapper-node andFoo=Bargenerates an alias. This aligns better with the LRM and brings the diffing items down to 88 differing, 125 identical, 75 only in vhdl-08.ungram, 25 only in vhdl-08-modified.ungram (previously: 133 differing, 68 identical, 87 only in LRM, 71 only in modified)