Skip to content

Stop requesting no longer existing renderer features#3475

Open
slipher wants to merge 3 commits intoUnvanquished:for-0.56.0/syncfrom
slipher:refentity-unimplemented
Open

Stop requesting no longer existing renderer features#3475
slipher wants to merge 3 commits intoUnvanquished:for-0.56.0/syncfrom
slipher:refentity-unimplemented

Conversation

@slipher
Copy link
Contributor

@slipher slipher commented Feb 18, 2026

Don't try to use renderer features which no longer exist:

  • refEntity_t::lightingOrigin field (something from GL 1)
  • Old shadow stuff e.g. inverse dynamic lights

@slipher
NUKE non-blob shadow code
1cd6b6b 
The engine-side code for shadow types other than blob has been gone for
a long time. Get rid of the nonfunctional cgame code relating to these
shadow types.
@slipher
Don't set refEntity_t's lightingOrigin
3226a27 
This does nothing in the renderer. I think it's a GL1-era thing where
you only get one light grid color for the whole model.
@slipher slipher force-pushed the refentity-unimplemented branch from 027630f to 3226a27 Compare February 18, 2026 08:25
@illwieckz
Copy link
Member

illwieckz commented Feb 18, 2026

Thank you ! Such clean-up is deeply appreciated.

@illwieckz
Copy link
Member

illwieckz commented Feb 18, 2026

Was this code actually executed (especially the CG_StartShadowCaster() one)? Can the removal of this speed-up the game a bit? Or is it just clean-up of dead code?

@VReaperV
Copy link
Contributor

VReaperV commented Feb 18, 2026

Don't set refEntity_t's lightingOrigin looks good, I had a commit somewhere that does the same.

The other commit seems fine too, but haven't tested yet.

@slipher
Copy link
Contributor Author

slipher commented Feb 18, 2026

Removed one more flag (RF_MINLIGHT).

Was this code actually executed (especially the CG_StartShadowCaster() one)? Can the removal of this speed-up the game a bit? Or is it just clean-up of dead code?

It should be impossible to set cg_shadows greater than 1, so no code was executed beyond the cvar test.

@illwieckz
Copy link
Member

illwieckz commented Feb 18, 2026

It should be impossible to set cg_shadows greater than 1, so no code was executed beyond the cvar test.

OK thanks. So dead code removal.

@VReaperV
Copy link
Contributor

VReaperV commented Feb 18, 2026

Remove no-op RF_MINLIGHT flag looks good too. Should be removed from engine too though.

@slipher slipher mentioned this pull request Feb 18, 2026
Open
@slipher
Copy link
Contributor Author

slipher commented Feb 18, 2026

Remove no-op RF_MINLIGHT flag looks good too. Should be removed from engine too though.

Yes: DaemonEngine/Daemon#1904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

T-Cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slipher @illwieckz @VReaperV

Comments