fix: update ONNX provider search and warn if GPU will not be used #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhdaines , please update to use https://github.com/Unstructured-IO/unstructured-inference/blob/main/unstructured_inference/logger.py . thanks for the contribution! |
Done! Sorry it took me a while to get around to it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yolox.pywas using a rather suspicious way of getting the available ONNX runtime providers, when there is a perfectly good function calledonnxruntime.get_available_providers()that it could be using instead.Also make it warn the user if CUDA is not present since they need to explicitly install a particular version of
onnxruntime-gpufor this to work (see Unstructured-IO/unstructured#2506 for details)