feat: implement parse_mailbox_list per issue #1 §3.4#15
Open
CuboYe wants to merge 2 commits into
Open
Conversation
Implements full ABNF grammar from §3.2-§3.4 with optional obsolete syntax support from §4.4. - RFC5322Address and AddressParser classes - parse() for single mailbox or group - parse_address_list() for comma-separated address lists - strict/non-strict mode for obsolete form handling - Includes comprehensive test suite
- parse_mailbox_list() rejects groups (per §3.4 mailbox-list ABNF) - 15/15 tests passing - Addresses gap identified in PR UnsafeLabs#6 review
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
parse_mailbox_list()method required by issue #1 acceptance criteria, plus 3 test cases covering simple lists, group rejection, and empty input.What was done
parser.py — added
parse_mailbox_list()(lines 284–310):mailbox-list = 1*mailbox *("," mailbox)parse_address_list(), this rejects groups — only mailboxes (addr-spec or name-addr forms) are acceptedValueErrorwhen a group is encounteredtest_parser.py — 3 new tests (15/15 passing):
test_parse_mailbox_list_simple: two mailbox addresses in a listtest_parse_mailbox_list_rejects_group: group in mailbox list raises ValueErrortest_parse_mailbox_list_empty: empty string and whitespace return []Test results
Note
This is a targeted fix for the one gap identified in PR #6. The existing PR #6 has broader scope (60+ tests required). This PR focuses only on the missing
parse_mailbox_listmethod. Happy to close either PR once one is merged — or the maintainer can cherry-pick if preferred.