Hermes [ T3 Code ] Add toast notification system with history panel#5451
Open
Jinyzhi wants to merge 2 commits into
Open
Hermes [ T3 Code ] Add toast notification system with history panel#5451Jinyzhi wants to merge 2 commits into
Jinyzhi wants to merge 2 commits into
Conversation
Closes UnsafeLabs#862 - notificationStore.ts: Zustand store with addNotification, dismissNotification, clearHistory - NotificationToast.tsx: Toast component with 4 types, auto-dismiss, enter/exit animations - NotificationHistoryPanel.tsx: History panel with date grouping, read/unread state - .provenance.json: AI agent metadata
zhangjiayang6835-cyber
left a comment
There was a problem hiding this comment.
PR Review: #5451 — Toast notification system
What looks correct:
- The Zustand store approach is well-structured with
addNotification,dismissNotification, andclearHistory - Components are properly separated (Toast vs HistoryPanel)
.provenance.jsonis included ✓
What needs improvement:
- No test files are included. The project requires tests for new functionality.
- TypeScript types could be stricter — consider exporting notification types for reuse.
- The PR title should include
[ T3 Code ]prefix as required by project conventions.
Suggestions:
- Add vitest tests for the notification store (add/dismiss/clear edge cases)
- Add tests for toast auto-dismiss behavior
- Update PR title to include
[ T3 Code ]prefix
Close to merge-ready, just needs tests and title fix.
- notificationStore.test.ts: 21 tests covering add/dismiss/clear/read/maxHistory - NotificationToast.test.tsx: 6 smoke tests for component rendering
Author
|
Thanks for the review! Addressed feedback: ✅ Tests added:
✅ PR title already includes ✅ Types — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a toast notification system with history panel for server events feedback.
Changes
notificationStore.ts— Zustand store withaddNotification,dismissNotification,clearHistory,markAsReadactions. Max 50 notifications in history, configurable auto-dismiss duration (default 5s).NotificationToast.tsx— Toast component rendering in top-right corner with:NotificationHistoryPanel.tsx— History panel showing last 50 notifications:.provenance.json— AI agent metadataAcceptance Criteria
.provenance.jsonincludedCloses #862
/bounty $40