[T3 Code] Surface rebase conflict status in git actions#5447
Open
yunrongy424-oss wants to merge 1 commit into
Open
[T3 Code] Surface rebase conflict status in git actions#5447yunrongy424-oss wants to merge 1 commit into
yunrongy424-oss wants to merge 1 commit into
Conversation
Expose unresolved git conflicts in the VCS status contract so RPC clients can distinguish ordinary working tree changes from active merge or rebase conflicts. Detect unmerged files from porcelain status and report the current conflict operation. Block Git UI actions while conflicts remain and show a focused resolution hint instead of letting commit, push, or PR flows proceed with an ambiguous dirty state. Refs UnsafeLabs#823 Co-Authored-By: Codex <noreply@openai.com>
zhangjiayang6835-cyber
left a comment
There was a problem hiding this comment.
PR Review: #5447 — Surfaces rebase conflict status
What looks correct:
- The approach of adding
conflictmetadata toVcsStatusis clean and minimal - Tests are included for the new conflict detection logic
- The porcelain v2 parsing approach is correct for detecting unmerged files
What needs improvement:
- The PR doesn't link to an issue. Please reference the relevant issue number so maintainers can track the bounty association.
- The change adds
is_conflictedboolean but doesn't expose which files have conflicts. Consider including the list of conflicted file paths.
Suggestions:
- Add a
.provenance.jsonfile as required by the project's contributing guidelines
Overall: Clean implementation, just needs issue reference and provenance metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #823