chore: refactor connector api so that an async variant can be created#382
Draft
sighphyre wants to merge 2 commits intochore/break-out-sync-apifrom
Draft
chore: refactor connector api so that an async variant can be created#382sighphyre wants to merge 2 commits intochore/break-out-sync-apifrom
sighphyre wants to merge 2 commits intochore/break-out-sync-apifrom
Conversation
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 19061071890Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures the connector APIs to be a bit cleaner and so that we can add in async variants of these. Effectively this only moves the
load_featureslogic from the abstract base class into a pure function so that it can be reused by async connectors, since those will need their own ABC