-
-
Notifications
You must be signed in to change notification settings - Fork 202
Panel restructure #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Panel restructure #1635
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@jamesmisson is attempting to deploy a commit to the BL UV team Team on Vercel. A member of the Team first needs to authorize it. |
bf70524 to
9f066ba
Compare
|
@jamesmisson, just a suggestion: I tend to find it most helpful to put TODO lists in the top comment so they don't get lost when GitHub starts collapsing things (which it tends to do in large PRs like this one if a lot of conversation occurs). |
This is a proposal for a new arrangement of the panel divs that has a few benefits for the feel of UV and for ease of future UI work.
Currently the mainPanel contains leftPanel, centerPanel, and rightPanel as siblings in a row. This means that when left and right panels are opened/closed, the center panel resizes, making the OSD image briefly flicker and transform.
This PR puts the OSD viewer in a new backgroundPanel which sits behind the left, center, and right panels, which are contained in a new overlayPanels div. The centerPanel is used as a transparent container for the various bits and pieces that overlay the image: image control buttons, paging buttons, OSD navigator, page mode buttons. This enables them to behave as authentic overlays rather than the illusion of overlays used in the current version of UV, which I think gives a more polished feel in general and prevents the image flicker on panel resize.
Besides cosmetic improvements, embracing the third dimension will allow more economical use of space when we try different arrangements of the transcription panel UI (e.g. it makes user-resizable panels easier to implement, and allows content to expand over other content if needs be).
Only the OSD extension has been given this treatment here, it currently breaks the AV extensions.
This depends on the new header and buttons PR here: #1557
EDIT: Some additional features:
To do