Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a LAN-accessible API endpoint to fetch a user’s calculated idle-lock and disable dates based on the stored last-login timestamp.
Changes:
- Added
/webroot/lan/api/expiry.phpreturning expiry dates (idlelock/disable) for a givenuid. - Exposed
UnitySQL::getUserLastLogin()publicly and updated functional tests to use it. - Added functional test coverage for the new API and documented
/lanwebserver configuration (plus dev Apache config example).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| webroot/lan/api/expiry.php | New JSON-like API endpoint computing idlelock/disable dates from SQL last-login. |
| tools/docker-dev/web/unity-apache.conf | Adds a /lan Apache location block for dev environments. |
| test/functional/ExpiryTest.php | Replaces reflection access with public getUserLastLogin(). |
| test/functional/ExpiryApiTest.php | New functional test for the expiry API endpoint. |
| resources/lib/UnitySQL.php | Makes getUserLastLogin() public to support API/tests. |
| README.md | Documents required /lan webserver configuration for the new endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bryank-cs
previously approved these changes
Feb 12, 2026
simonLeary42
force-pushed
the
expiry-api
branch
from
f96432b to
591c336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.