-
Notifications
You must be signed in to change notification settings - Fork 460
fix: add better error messages for a couple of error cases #3739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- When using a generic INetworkSerializable+IEquatable combo and update documentation with workaround - When there are no initialized elements in the network prefab list (fix null reference exception)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made some minor tweaks, but the rest looks good!
👍
Thank you Laurus! 🙌
com.unity.netcode.gameobjects/Tests/Editor/NetworkManagerConfigurationTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Just some small notes.
I think there might also be an issue when the list itself has a null prefab. I'm not sure if this fix catches that?
com.unity.netcode.gameobjects/Runtime/Configuration/NetworkPrefabs.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Tests/Editor/NetworkManagerConfigurationTests.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/basics/networkvariable.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/basics/networkvariable.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/basics/networkvariable.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/basics/networkvariable.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/basics/networkvariable.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/basics/networkvariable.md
Outdated
Show resolved
Hide resolved
This is already handled, this will emit an error message |
Purpose of this PR
add better error messages for a couple of error cases
Example error printed with the generic IEquatable error is
which is printed in addition to the usual error for not implementing IEquatable.
Jira ticket
MTTB-1202
MTTB-1306
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Manually tested the codegen errors with IEquatable.
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
coming if needed