Skip to content

Conversation

@michalChrobot
Copy link
Collaborator

@michalChrobot michalChrobot commented Oct 23, 2025

Purpose of this PR

This PR aims to update few recently released dependencies and cleanup some unused defines in the code.

  1. It bumps com.unity.services.multiplayer package to 1.2.0 which contains changes related to @EmandM changes with NetworkManager so I think it's worth to bump in this case.
  2. It bumps com.unity.transport to 2.6.0 since this resolves MTU issues when using VPN or similar service so I think this is a useful change to "enfornce"
    3. It removes the usage of MULTIPLAYER_TOOLS_1_0_0_PRE_7 since first of all 1.X is not supported anymore and based on editor manifest in all editors that NGO 2.X supports Tools package of version 2.X is required so we can be sure that nothing lower then 1.0.0-pre.7 version of tools is used in any project Actually I didn't account for the fact that you don't need to use MP Tools so this define needs to stay
  3. It removes the usage of UNITY_UNET_PRESENT related files since this would be valid on editors below 2022.2.0a5 and NGOv2.X offers support for 6000.0+ editors. Note that this define + related files will still be available for NGOv1.X and develop branch if someone wants to inspect/use them

Additionally

  • I noticed that com.unity.test-framework (which we are using in testproject) is available from 6000.0.44f1 editor so I bumped the default editor for the project

I will follow up on this PR with dependency updates in BossRoom and Asteroids (com.unity.services.multiplayer and com.unity.transport)

Jira ticket

N/A

Changelog

Not sure if it's worth adding information about the defines to the changelog since I doubt anyone is using them but we can do it just for sanity

  • Changed: Updated transport dependency of the package to 2.6.0
  • Removed: Removed usage of MULTIPLAYER_TOOLS_1_0_0_PRE_7 and UNITY_UNET_PRESENT defines

Documentation

N/A

Testing & QA (How your changes can be verified during release Playtest)

I played around in the projects modified so this + green CI pass should be enough

Backports

N/A

@michalChrobot michalChrobot self-assigned this Oct 23, 2025
@michalChrobot michalChrobot marked this pull request as ready for review October 23, 2025 08:16
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

Thank you @michalChrobot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants