Refactor GRIB collection handling to use MFile abstractions#1547
Merged
lesserwhirls merged 1 commit intoUnidata:maint-5.xfrom Apr 9, 2026
Merged
Refactor GRIB collection handling to use MFile abstractions#1547lesserwhirls merged 1 commit intoUnidata:maint-5.xfrom
lesserwhirls merged 1 commit intoUnidata:maint-5.xfrom
Conversation
* replace several file/path-based lookups with managed MFile-based access * update inventory controllers to expose a DirectoryStream<MFile> interface * handle GRIB index creation, caching, and temporary file naming with shared helpers
lesserwhirls
added
internal: collections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This will allow for local GRIB and CDM index files to be created to manage non-local (e.g. S3) GRIB collections. I don't think we will extend netCDF-Java to support writing these index files to non-local storage; that will be a job for a specialized tool like the TDM, which those that control the non-local data would be in the best position to run. This PR, along with #1544 and #1545 should effectively close #1177.
PR Checklist
until ready for review