Validate smart macro event names#1541
Closed
kareltucek wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
Closed
Validate smart macro event names#1541kareltucek wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
kareltucek wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
Conversation
Macro names that begin with `$` are treated as event handlers (e.g. `$onInit`, `$onKeymapChange`, `$onLayerChange`). Until now, unknown event names like `$onKeyMapChange` (camel-case typo) were silently ignored, leaving the user with a non-functional handler and no diagnostic. Walk all macros after Macros_ValidateAllMacros and emit a status buffer error for any `$`-prefixed name that doesn't match a known event, has the wrong number of arguments, or specifies a layer name that Macros_ConsumeLayerId rejects. Refs UltimateHackingKeyboard#1536
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macro names that begin with
$are treated as event handlers(e.g.
$onInit,$onKeymapChange,$onLayerChange). Until now,unknown event names like
$onKeyMapChange(camel-case typo) weresilently ignored, leaving the user with a non-functional handler and
no diagnostic.
Walk all macros after Macros_ValidateAllMacros and emit a status
buffer error for any
$-prefixed name that doesn't match a knownevent, has the wrong number of arguments, or specifies a layer name
that Macros_ConsumeLayerId rejects.
Refs #1536