Skip to content

Fix secondary role wording. #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kareltucek merged 3 commits into from
May 6, 2026
+6 −6
Merged

Fix secondary role wording. #2905

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
401630a
Fix secondary role wording.
kareltucek May 4, 2026
3b9b549
Don't trigger HRMs on same side triggers by default.
kareltucek May 6, 2026
0c1fbda
Merge remote-tracking branch 'origin/master' into fix_suppress_trigge…
kareltucek May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...es/uhk-common/src/config-serializer/config-items/advanced-secondary-role-configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const SIMPLE_ADVANCED_SECONDARY_ROLE_CONFIGURATION_PRESET: AdvancedSecond
secondaryRoleAdvancedStrategySafetyMargin: 0,
secondaryRoleAdvancedStrategyDoubletapToPrimary: false,
secondaryRoleAdvancedStrategyTriggerByMouse: true,
secondaryRoleAdvancedStrategyTriggerFromSameHalf: false,
secondaryRoleAdvancedStrategyTriggerFromSameHalf: true,
}
}

Expand All @@ -69,9 +69,9 @@ export const HRM_TIMEOUT_CANCEL_ADVANCED_SECONDARY_ROLE_CONFIGURATION_PRESET: Ad
secondaryRoleAdvancedStrategyTimeoutType: SecondaryRoleAdvancedStrategyTimeoutType.Passive,
secondaryRoleAdvancedStrategyTrigger: SecondaryRoleAdvancedStrategyTriggeringEvent.Release,
secondaryRoleAdvancedStrategySafetyMargin: -40,
secondaryRoleAdvancedStrategyDoubletapToPrimary: true,
secondaryRoleAdvancedStrategyDoubletapToPrimary: false,
secondaryRoleAdvancedStrategyTriggerByMouse: true,
secondaryRoleAdvancedStrategyTriggerFromSameHalf: false,
secondaryRoleAdvancedStrategyTriggerFromSameHalf: true,
}
}

Expand All @@ -86,9 +86,9 @@ export const HRM_TIMEOUT_SECONDARY_ADVANCED_SECONDARY_ROLE_CONFIGURATION_PRESET:
secondaryRoleAdvancedStrategyTimeoutType: SecondaryRoleAdvancedStrategyTimeoutType.Active,
secondaryRoleAdvancedStrategyTrigger: SecondaryRoleAdvancedStrategyTriggeringEvent.Release,
secondaryRoleAdvancedStrategySafetyMargin: 1,
secondaryRoleAdvancedStrategyDoubletapToPrimary: true,
secondaryRoleAdvancedStrategyDoubletapToPrimary: false,
secondaryRoleAdvancedStrategyTriggerByMouse: false,
secondaryRoleAdvancedStrategyTriggerFromSameHalf: false,
secondaryRoleAdvancedStrategyTriggerFromSameHalf: true,
}
}

Expand All @@ -105,7 +105,7 @@ export const TIMEOUT_ADVANCED_SECONDARY_ROLE_CONFIGURATION_PRESET: AdvancedSecon
secondaryRoleAdvancedStrategySafetyMargin: 0,
secondaryRoleAdvancedStrategyDoubletapToPrimary: true,
secondaryRoleAdvancedStrategyTriggerByMouse: true,
secondaryRoleAdvancedStrategyTriggerFromSameHalf: false,
secondaryRoleAdvancedStrategyTriggerFromSameHalf: true,
}
}

Expand Down
Loading