test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions#49
Merged
sh3ifu merged 2 commits intoJun 17, 2026
Conversation
crawter
approved these changes
Jun 17, 2026
…#51) * fix(R-I-18): reject proposals with deadline shorter than the timelock * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions (#52) * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge (#55) * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge * test(R-I-11): destinationAddress / sourceAddress length-cap regressions (#56) * test(R-I-11): destinationAddress / sourceAddress length-cap regressions * fix(R-I-12): cap proof length in Bridge.fundsOut (#57) * fix(R-I-12): cap proof length in Bridge.fundsOut * test(R-I-12): proof length-cap regressions for fundsOut (#58) * test(R-I-12): proof length-cap regressions for fundsOut * fix(R-W-12): enforce strict-majority signer threshold floor (#60) * fix(R-W-12): enforce strict-majority signer threshold floor * test(R-W-12): strict-majority signer threshold regressions (#61) * test(R-W-12): strict-majority signer threshold regressions * fix(R-W-14): require disjoint enclave and federation signer sets (#62) * fix(R-W-14): require disjoint enclave and federation signer sets * test(R-W-14): disjoint signer-set regressions (#63) * test(R-W-14): disjoint signer-set regressions * fix(R-I-06): cap signer-set size at MAX_SIGNERS (#64) * fix(R-I-06): cap signer-set size at MAX_SIGNERS * test(R-I-06): signer-set size cap regressions (#65)
sh3ifu
merged commit c837176
into
multisig-R-I-01-tee-deadline-upper-bound-fix
2 checks passed
sh3ifu
added a commit
that referenced
this pull request
Jun 17, 2026
…INE (#48) * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions (#49) * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions * fix(R-I-18): reject proposals with deadline shorter than the timelock (#51) * fix(R-I-18): reject proposals with deadline shorter than the timelock * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions (#52) * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge (#55) * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge * test(R-I-11): destinationAddress / sourceAddress length-cap regressions (#56) * test(R-I-11): destinationAddress / sourceAddress length-cap regressions * fix(R-I-12): cap proof length in Bridge.fundsOut (#57) * fix(R-I-12): cap proof length in Bridge.fundsOut * test(R-I-12): proof length-cap regressions for fundsOut (#58) * test(R-I-12): proof length-cap regressions for fundsOut * fix(R-W-12): enforce strict-majority signer threshold floor (#60) * fix(R-W-12): enforce strict-majority signer threshold floor * test(R-W-12): strict-majority signer threshold regressions (#61) * test(R-W-12): strict-majority signer threshold regressions * fix(R-W-14): require disjoint enclave and federation signer sets (#62) * fix(R-W-14): require disjoint enclave and federation signer sets * test(R-W-14): disjoint signer-set regressions (#63) * test(R-W-14): disjoint signer-set regressions * fix(R-I-06): cap signer-set size at MAX_SIGNERS (#64) * fix(R-I-06): cap signer-set size at MAX_SIGNERS * test(R-I-06): signer-set size cap regressions (#65)
sh3ifu
added a commit
that referenced
this pull request
Jun 17, 2026
…ts (#47) * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE (#48) * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions (#49) * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions * fix(R-I-18): reject proposals with deadline shorter than the timelock (#51) * fix(R-I-18): reject proposals with deadline shorter than the timelock * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions (#52) * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge (#55) * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge * test(R-I-11): destinationAddress / sourceAddress length-cap regressions (#56) * test(R-I-11): destinationAddress / sourceAddress length-cap regressions * fix(R-I-12): cap proof length in Bridge.fundsOut (#57) * fix(R-I-12): cap proof length in Bridge.fundsOut * test(R-I-12): proof length-cap regressions for fundsOut (#58) * test(R-I-12): proof length-cap regressions for fundsOut * fix(R-W-12): enforce strict-majority signer threshold floor (#60) * fix(R-W-12): enforce strict-majority signer threshold floor * test(R-W-12): strict-majority signer threshold regressions (#61) * test(R-W-12): strict-majority signer threshold regressions * fix(R-W-14): require disjoint enclave and federation signer sets (#62) * fix(R-W-14): require disjoint enclave and federation signer sets * test(R-W-14): disjoint signer-set regressions (#63) * test(R-W-14): disjoint signer-set regressions * fix(R-I-06): cap signer-set size at MAX_SIGNERS (#64) * fix(R-I-06): cap signer-set size at MAX_SIGNERS * test(R-I-06): signer-set size cap regressions (#65)
sh3ifu
added a commit
that referenced
this pull request
Jun 17, 2026
…ns (#46) * test(R-I-07,R-I-08): min fundsIn amount + zero-amount guard regressions * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts (#47) * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE (#48) * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions (#49) * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions * fix(R-I-18): reject proposals with deadline shorter than the timelock (#51) * fix(R-I-18): reject proposals with deadline shorter than the timelock * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions (#52) * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge (#55) * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge * test(R-I-11): destinationAddress / sourceAddress length-cap regressions (#56) * test(R-I-11): destinationAddress / sourceAddress length-cap regressions * fix(R-I-12): cap proof length in Bridge.fundsOut (#57) * fix(R-I-12): cap proof length in Bridge.fundsOut * test(R-I-12): proof length-cap regressions for fundsOut (#58) * test(R-I-12): proof length-cap regressions for fundsOut * fix(R-W-12): enforce strict-majority signer threshold floor (#60) * fix(R-W-12): enforce strict-majority signer threshold floor * test(R-W-12): strict-majority signer threshold regressions (#61) * test(R-W-12): strict-majority signer threshold regressions * fix(R-W-14): require disjoint enclave and federation signer sets (#62) * fix(R-W-14): require disjoint enclave and federation signer sets * test(R-W-14): disjoint signer-set regressions (#63) * test(R-W-14): disjoint signer-set regressions * fix(R-I-06): cap signer-set size at MAX_SIGNERS (#64) * fix(R-I-06): cap signer-set size at MAX_SIGNERS * test(R-I-06): signer-set size cap regressions (#65)
sh3ifu
added a commit
that referenced
this pull request
Jun 17, 2026
…mount fundsOut guard (#45) * fix(R-I-07,R-I-08): enforce a non-zero minimum fundsIn amount; zero-amount fundsOut guard * test(R-I-07,R-I-08): min fundsIn amount + zero-amount guard regressions (#46) * test(R-I-07,R-I-08): min fundsIn amount + zero-amount guard regressions * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts (#47) * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE (#48) * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions (#49) * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions * fix(R-I-18): reject proposals with deadline shorter than the timelock (#51) * fix(R-I-18): reject proposals with deadline shorter than the timelock * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions (#52) * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge (#55) * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge * test(R-I-11): destinationAddress / sourceAddress length-cap regressions (#56) * test(R-I-11): destinationAddress / sourceAddress length-cap regressions * fix(R-I-12): cap proof length in Bridge.fundsOut (#57) * fix(R-I-12): cap proof length in Bridge.fundsOut * test(R-I-12): proof length-cap regressions for fundsOut (#58) * test(R-I-12): proof length-cap regressions for fundsOut * fix(R-W-12): enforce strict-majority signer threshold floor (#60) * fix(R-W-12): enforce strict-majority signer threshold floor * test(R-W-12): strict-majority signer threshold regressions (#61) * test(R-W-12): strict-majority signer threshold regressions * fix(R-W-14): require disjoint enclave and federation signer sets (#62) * fix(R-W-14): require disjoint enclave and federation signer sets * test(R-W-14): disjoint signer-set regressions (#63) * test(R-W-14): disjoint signer-set regressions * fix(R-I-06): cap signer-set size at MAX_SIGNERS (#64) * fix(R-I-06): cap signer-set size at MAX_SIGNERS * test(R-I-06): signer-set size cap regressions (#65)
sh3ifu
added a commit
that referenced
this pull request
Jun 17, 2026
#44) * test(R-W-03): fee-shape invariant regression for CommissionManager setters * fix(R-I-07,R-I-08): enforce a non-zero minimum fundsIn amount; zero-amount fundsOut guard (#45) * fix(R-I-07,R-I-08): enforce a non-zero minimum fundsIn amount; zero-amount fundsOut guard * test(R-I-07,R-I-08): min fundsIn amount + zero-amount guard regressions (#46) * test(R-I-07,R-I-08): min fundsIn amount + zero-amount guard regressions * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts (#47) * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE (#48) * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions (#49) * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions * fix(R-I-18): reject proposals with deadline shorter than the timelock (#51) * fix(R-I-18): reject proposals with deadline shorter than the timelock * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions (#52) * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge (#55) * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge * test(R-I-11): destinationAddress / sourceAddress length-cap regressions (#56) * test(R-I-11): destinationAddress / sourceAddress length-cap regressions * fix(R-I-12): cap proof length in Bridge.fundsOut (#57) * fix(R-I-12): cap proof length in Bridge.fundsOut * test(R-I-12): proof length-cap regressions for fundsOut (#58) * test(R-I-12): proof length-cap regressions for fundsOut * fix(R-W-12): enforce strict-majority signer threshold floor (#60) * fix(R-W-12): enforce strict-majority signer threshold floor * test(R-W-12): strict-majority signer threshold regressions (#61) * test(R-W-12): strict-majority signer threshold regressions * fix(R-W-14): require disjoint enclave and federation signer sets (#62) * fix(R-W-14): require disjoint enclave and federation signer sets * test(R-W-14): disjoint signer-set regressions (#63) * test(R-W-14): disjoint signer-set regressions * fix(R-I-06): cap signer-set size at MAX_SIGNERS (#64) * fix(R-I-06): cap signer-set size at MAX_SIGNERS * test(R-I-06): signer-set size cap regressions (#65)
sh3ifu
added a commit
that referenced
this pull request
Jun 17, 2026
… time (#43) * fix(R-W-03): reject stablePercent > multiplier^2 at commission config time * test(R-W-03): fee-shape invariant regression for CommissionManager se… (#44) * test(R-W-03): fee-shape invariant regression for CommissionManager setters * fix(R-I-07,R-I-08): enforce a non-zero minimum fundsIn amount; zero-amount fundsOut guard (#45) * fix(R-I-07,R-I-08): enforce a non-zero minimum fundsIn amount; zero-amount fundsOut guard * test(R-I-07,R-I-08): min fundsIn amount + zero-amount guard regressions (#46) * test(R-I-07,R-I-08): min fundsIn amount + zero-amount guard regressions * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts (#47) * chore(R-I-07,R-I-08): pass minFundsInAmount to Bridge in deploy scripts * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE (#48) * fix(R-I-01): bound TEE execute/executeBatch deadline to MAX_TEE_DEADLINE * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions (#49) * test(R-I-01): TEE execute/executeBatch deadline upper-bound regressions * fix(R-I-18): reject proposals with deadline shorter than the timelock (#51) * fix(R-I-18): reject proposals with deadline shorter than the timelock * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions (#52) * test(R-I-18): proposal deadline-vs-timelock lower-bound regressions * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge (#55) * fix(R-I-11): cap destinationAddress / sourceAddress length in Bridge * test(R-I-11): destinationAddress / sourceAddress length-cap regressions (#56) * test(R-I-11): destinationAddress / sourceAddress length-cap regressions * fix(R-I-12): cap proof length in Bridge.fundsOut (#57) * fix(R-I-12): cap proof length in Bridge.fundsOut * test(R-I-12): proof length-cap regressions for fundsOut (#58) * test(R-I-12): proof length-cap regressions for fundsOut * fix(R-W-12): enforce strict-majority signer threshold floor (#60) * fix(R-W-12): enforce strict-majority signer threshold floor * test(R-W-12): strict-majority signer threshold regressions (#61) * test(R-W-12): strict-majority signer threshold regressions * fix(R-W-14): require disjoint enclave and federation signer sets (#62) * fix(R-W-14): require disjoint enclave and federation signer sets * test(R-W-14): disjoint signer-set regressions (#63) * test(R-W-14): disjoint signer-set regressions * fix(R-I-06): cap signer-set size at MAX_SIGNERS (#64) * fix(R-I-06): cap signer-set size at MAX_SIGNERS * test(R-I-06): signer-set size cap regressions (#65)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R-I-01 — regression tests (UT-FIX-23)
Unit tests for the
MAX_TEE_DEADLINEceiling added toexecute/executeBatchin the fix PR.Coverage
executeandexecuteBatchrevertDeadlineTooFarwhendeadline > now + MAX_TEE_DEADLINE.now + MAX_TEE_DEADLINE) is accepted and fully executes(guard is a strict
>).proxy.MAX_TEE_DEADLINE(), so the tests don't hardcode thevalue.