fix(R-I-07,R-I-08): enforce a non-zero minimum fundsIn amount; zero-amount fundsOut guard#45
Open
sh3ifu wants to merge 1 commit into
Conversation
…mount fundsOut guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R-I-07 + R-I-08 — zero-amount and dust deposits
Closes two related findings with one coherent change on the inbound path.
fundsIn/fundsOutacceptedamount == 0, a no-opthat only emitted redundant events.
amount * stablePercent / multiplier^2floors to zero bridged with no commission (event/processing noise).Change
minFundsInAmount— constructor arg +onlyOwnersetMinFundsInAmount.Validated non-zero at both the constructor and the setter
(
InvalidMinFundsInAmount). A non-zero floor is the single invariant thatcloses both findings on the inbound path. Units: token smallest units
(USDT0 = 6 decimals).
fundsIn— one check:amount < minFundsInAmount→AmountBelowMinimum.Since the floor is always non-zero, zero-amount deposits revert here too, so
R-I-07 stays closed regardless of config.
fundsOut—amount == 0→ZeroAmountonly. No minimum: it is anauthorized release of an already-recorded amount (incl. residual partial
consumes from
RgbSettlementModule), and a floor could block legitimate smallreleases.
Governance
setMinFundsInAmountisonlyOwner(owner = MultisigProxy). The federationretunes it through the existing generic
proposeAdminExecute→ timelock →executeProposalflow — no MultisigProxy changes, no new EIP-712 typehash.