test(R-W-03): fee-shape invariant regression for CommissionManager se…#44
Open
sh3ifu wants to merge 1 commit into
Open
test(R-W-03): fee-shape invariant regression for CommissionManager se…#44sh3ifu wants to merge 1 commit into
sh3ifu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R-W-03 / UT-FIX-06 — fee-shape invariant regression tests
Unit-test group for the
stablePercent <= multiplier^2invariant added toCommissionManager.setGlobalDefaultsandsetCommissionRule(fix PR for R-W-03).Coverage
InvalidFeeShapeon the audit's brick config(9000, 1)and atthe just-above boundary
(101, 10), for both setters.stablePercent == multiplier^2(100% fee,netAmount = 0, no underflow).(9000, 100)with the default multiplier — regression for theuint256 widening in the fix. The audit's literal
multiplier * multiplierwould overflow uint8 at
100 * 100and wrongly reject this valid 90% config.fee == amount/net == 0incalculateFundsInCommissionwithout underflowing.