fix(R-W-03): reject stablePercent > multiplier^2 at commission config time#43
Open
sh3ifu wants to merge 1 commit into
Open
fix(R-W-03): reject stablePercent > multiplier^2 at commission config time#43sh3ifu wants to merge 1 commit into
sh3ifu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R-W-03 — Commission config can accept fee shapes that brick the route
Problem
CommissionManager.setGlobalDefaultsandsetCommissionRulevalidatedstablePercentandmultiplieronly individually. The fee formulastableFee = amount * stablePercent / multiplier^2means that whenstablePercent > multiplier^2the quoted fee exceeds the bridged amount,netAmount = amount - feeunderflows with Panic(0x11), and every subsequentfundsIn/fundsOuton that route reverts until the federation fixes the configthrough the timelock. Example brick config:
(stablePercent = 9000, multiplier = 1).Fix
Enforce the joint invariant
stablePercent <= multiplier^2at both setters,reverting
InvalidFeeShape(stablePercent, multiplier)otherwise.stablePercent == multiplier^2(100% fee,netAmount = 0) is intentionallystill allowed — it does not underflow.