-
Notifications
You must be signed in to change notification settings - Fork 16
Updates to ROI analysis #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sakshimohan
wants to merge
35
commits into
master
Choose a base branch
from
sakshi/comparison_of_horizontal_v_vertical_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Updates to ROI analysis #1711
sakshimohan
wants to merge
35
commits into
master
from
sakshi/comparison_of_horizontal_v_vertical_v2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Note that Xpert costs no longer need to be estimated separately.
…Plane + Add ROI bar plots at two implementation cost assumptions
+ fix calculation of roi at upper bound ASC + formatting fixes to plots
(Note that the RF should be taken from branch - tara/gff_hss_and_htm_scale_up
…opposed to 50% as previously assumed (i.e. weighted average of cost for uncomplicated and complicated cases) as opposed to simple average.
Collaborator
Author
|
Will request review once the manuscript has been accepted in its current form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the scripts abd RF used to produce the results for the following papers -