ci: Bump mac runners to macos-15-intel - #463
Merged
Merged
Conversation
Merged
macos-13 is being deprecated now. Stick with intel runners for now, since the MacOS code signing and notarization situation is still not solved, which would be mandatory for usable aarch64 build.
arch1t3cht
force-pushed
the
mac-ci
branch
3 times, most recently
from
November 17, 2025 12:04
1ac6d13 to
7599e5d
Compare
iconv on macos 15 (in particular github's macos-15-intel runners) removes any null bytes when converting from utf-8 to wchar_t, which causes an assertion error in nul_size() when converting to wchar_t (which in turn causes the corresponding test to fail). This did not happen on macos 13 (in particular github's old macos-13 runners); there the same conversion would preserve null bytes normally. After plorkyeran's large refactor, the entire nul_size logic is no longer needed anyway and can be removed entirely, which will be done in the next commit.
This is no longer needed after plorkyeran's refactor since the conversion functions no longer take C strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos-13 is being deprecated now.
Stick with intel runners for now, since the MacOS code signing and notarization situation is still not solved, which would be mandatory for usable aarch64 build.
PR created to test CI.