Skip to content

Allow \an in SubRip #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow \an in SubRip #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/subtitle_format_srt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,9 @@ bool SRTSubtitleFormat::CanSave(const AssFile *file) const {
for (auto ovr : blocks | agi::of_type<AssDialogueBlockOverride>()) {
// Verify that all overrides used are supported
for (auto const& tag : ovr->Tags) {
if (tag.Name.size() != 2)
if (tag.Name.size() != 2 && tag.Name != "\\an")
return false;
if (!strchr("bisu", tag.Name[1]))
if (tag.Name.size() == 2 && !strchr("bisu", tag.Name[1]))
return false;
}
}
Expand All @@ -489,7 +489,13 @@ std::string SRTSubtitleFormat::ConvertTags(const AssDialogue *diag) const {
switch (block->GetType()) {
case AssBlockType::OVERRIDE:
for (auto const& tag : static_cast<AssDialogueBlockOverride&>(*block).Tags) {
if (!tag.IsValid() || tag.Name.size() != 2)
if (!tag.IsValid())
continue;
if (tag.Name == "\\an") {
final += agi::format("{%s}", std::string(tag));
continue;
}
if (tag.Name.size() != 2)
continue;
for (auto& state : tag_states) {
if (state.tag != tag.Name[1]) continue;
Expand Down