Skip to content

feat(NOJIRA-1234): --ignore-scripts in yarn install #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidsalvador-tf merged 2 commits into from
Apr 9, 2026
+16 −5
Merged

feat(NOJIRA-1234): --ignore-scripts in yarn install #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f87b09
feat(NOJIRA-1234): --ignore-scripts in yarn install to mitigate suppl…
davidsalvador-tf Apr 1, 2026
381ba49
Merge branch 'main' into NOJIRA-1234-harden-yarn-install
pannago Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions shared-actions/setup-node-with-cache/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,15 +247,17 @@ runs:
NEEDS_INSTALL=true
fi

# 3. Postinstall hook: Any project with postinstall needs it executed
# Examples: building native modules, generating files, running setup scripts
# 3. Postinstall hook: install needed so we can run the root postinstall explicitly
# (dependency postinstall scripts are blocked by --ignore-scripts)
if grep -q '"postinstall"' package.json 2>/dev/null; then
echo "🔧 Detected postinstall hook - install needed to execute it"
echo "🔧 Detected postinstall hook - install needed to run root postinstall"
NEEDS_INSTALL=true
HAS_POSTINSTALL=true
fi
fi

echo "needs-install=$NEEDS_INSTALL" >> $GITHUB_OUTPUT
echo "has-postinstall=${HAS_POSTINSTALL:-false}" >> $GITHUB_OUTPUT

- name: Log cache status and decision
if: ${{ !env.ACT }}
Expand Down Expand Up @@ -284,7 +286,16 @@ runs:
- name: Install Node.js dependencies
if: ${{ !env.ACT && (steps.yarn-cache.outputs.cache-hit != 'true' || steps.check-install-needed.outputs.needs-install == 'true') }}
shell: bash
run: yarn install --frozen-lockfile
run: yarn install --frozen-lockfile --ignore-scripts
env:
NODE_AUTH_TOKEN: ${{ inputs.GH_TOKEN }}
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: 'true'

- name: Run root postinstall script
if: ${{ !env.ACT && steps.check-install-needed.outputs.has-postinstall == 'true' }}
shell: bash
run: |
echo "🔧 Running root postinstall script"
yarn run postinstall
env:
NODE_AUTH_TOKEN: ${{ inputs.GH_TOKEN }}
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: 'true'