(broken) native streams #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: jszip assumes we have a way to syncronously finish these in end() and flush(). we don't...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fully work, but it shows that this might work
Issue is that jszip streams were not designed around the fully async model that web streams are. For example jszip streams have an end() and flush() that are supposed to synchronously finish stuff. Not possible with the web stream.
Some other concerns are that the outputs might not be bit-for-bit identical anymore, and we'll have to lose the compression level option
It might be best if we can skip the DataWorker entirely and just pass the entire thing to the native stream since those probably run on another thread anyways?