Hide burger menu icon if navigation is empty#363
Open
leoxiong wants to merge 1 commit intoTryGhost:mainfrom
Open
Hide burger menu icon if navigation is empty#363leoxiong wants to merge 1 commit intoTryGhost:mainfrom
leoxiong wants to merge 1 commit intoTryGhost:mainfrom
Conversation
Contributor
Author
|
@minimaluminium please review when you have a moment. |
markstos
suggested changes
Apr 19, 2025
Contributor
markstos
left a comment
markstos
left a comment
There was a problem hiding this comment.
Makes sense, but seems like a mistake that this PR changed the permissions of some built JavaScript files. Consider revising the commit to remove those files from the commit.
This PR will conflict as #413 as both touch the burger menu line across all sites. Whichever PR is landed second will have conflicts to resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the primary navigation has no items, the burger menu is still shown on mobile.