Task 6#6
Open
Trinity-142 wants to merge 2 commits into
Open
Conversation
ugliansky
requested changes
Apr 6, 2026
| } | ||
|
|
||
| SquareMatrix operator+(const SquareMatrix& other) const { | ||
| assert(_size == other._size); |
Collaborator
There was a problem hiding this comment.
Assertion is something that should never happen, but this... well it could happen, right? If user will give you the wrong matrix. I suggest to throw an exception here instead
| return !(*this == other); | ||
| } | ||
|
|
||
| T* operator[](size_t i) { |
Collaborator
There was a problem hiding this comment.
while this will work, there are some problems with such solution.
First of all: it would be nice to have some boundary checks, when index is too big, an exception is a better solution than UB. This is true for both dimensions!
Also, returning a raw pointer to the user looks like breaking the encapsulation. He could access elements from the other Row or just call delete on it! Looks unsafe.
Let's try to think how to solve these problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.